Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp

Issue 22819015: PNaCl bitcode: Remove support for TYPE_CODE_FUNCTION_OLD (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp
diff --git a/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp b/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp
index 1bbbf4516a6e5a2424cc530b5f2b05d6bb11ed84..eab4bc06bcc7eda7898baabf892f0e5616285402 100644
--- a/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp
+++ b/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp
@@ -480,26 +480,6 @@ bool NaClBitcodeReader::ParseTypeTableBody() {
ResultTy = PointerType::get(ResultTy, AddressSpace);
break;
}
- case naclbitc::TYPE_CODE_FUNCTION_OLD: {
- // FIXME: attrid is dead, remove it in LLVM 4.0
- // FUNCTION: [vararg, attrid, retty, paramty x N]
- if (Record.size() < 3)
- return Error("Invalid FUNCTION type record");
- SmallVector<Type*, 8> ArgTys;
- for (unsigned i = 3, e = Record.size(); i != e; ++i) {
- if (Type *T = getTypeByID(Record[i]))
- ArgTys.push_back(T);
- else
- break;
- }
-
- ResultTy = getTypeByID(Record[2]);
- if (ResultTy == 0 || ArgTys.size() < Record.size()-3)
- return Error("invalid type in function type");
-
- ResultTy = FunctionType::get(ResultTy, ArgTys, Record[0]);
- break;
- }
case naclbitc::TYPE_CODE_FUNCTION: {
// FUNCTION: [vararg, retty, paramty x N]
if (Record.size() < 2)
« no previous file with comments | « include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698