Issue 22819015: PNaCl bitcode: Remove support for TYPE_CODE_FUNCTION_OLD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22819015: PNaCl bitcode: Remove support for TYPE_CODE_FUNCTION_OLD (Closed)

Created:
7 years, 4 months ago by Mark Seaborn

Modified:
7 years, 4 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

PNaCl bitcode: Remove support for TYPE_CODE_FUNCTION_OLD PNaCl uses TYPE_CODE_FUNCTION instead, as you'd expect. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3590 TEST=PNaCl toolchain trybots Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=bbdf86f

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -22 lines)			Patch
	M	include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp	View		1 chunk	+0 lines, -20 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Seaborn

7 years, 4 months ago (2013-08-23 23:47:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rbbdf86f (presubmit successful).