Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: Source/core/html/HTMLMediaElement.cpp

Issue 22791003: Make media controls keyboard accessible Base URL: http://src.chromium.org/blink/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 // FIXME: This is a temporary fix to prevent this object from causing the 363 // FIXME: This is a temporary fix to prevent this object from causing the
364 // MediaPlayer to dereference Frame and FrameLoader pointers from the 364 // MediaPlayer to dereference Frame and FrameLoader pointers from the
365 // previous document. A proper fix would provide a mechanism to allow this 365 // previous document. A proper fix would provide a mechanism to allow this
366 // object to refresh the MediaPlayer's Frame and FrameLoader references on 366 // object to refresh the MediaPlayer's Frame and FrameLoader references on
367 // document changes so that playback can be resumed properly. 367 // document changes so that playback can be resumed properly.
368 userCancelledLoad(); 368 userCancelledLoad();
369 369
370 HTMLElement::didMoveToNewDocument(oldDocument); 370 HTMLElement::didMoveToNewDocument(oldDocument);
371 } 371 }
372 372
373 bool HTMLMediaElement::hasCustomFocusLogic() const
374 {
375 return true;
376 }
377
378 bool HTMLMediaElement::supportsFocus() const 373 bool HTMLMediaElement::supportsFocus() const
379 { 374 {
380 if (ownerDocument()->isMediaDocument())
381 return false;
382
383 // If no controls specified, we should still be able to focus the element if it has tabIndex. 375 // If no controls specified, we should still be able to focus the element if it has tabIndex.
384 return controls() || HTMLElement::supportsFocus(); 376 return controls() || HTMLElement::supportsFocus();
385 } 377 }
386 378
387 bool HTMLMediaElement::isMouseFocusable() const 379 bool HTMLMediaElement::isMouseFocusable() const
388 { 380 {
389 return false; 381 return false;
390 } 382 }
391 383
392 void HTMLMediaElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 384 void HTMLMediaElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
(...skipping 3580 matching lines...) Expand 10 before | Expand all | Expand 10 after
3973 { 3965 {
3974 m_restrictions = NoRestrictions; 3966 m_restrictions = NoRestrictions;
3975 } 3967 }
3976 3968
3977 void HTMLMediaElement::mediaPlayerScheduleLayerUpdate() 3969 void HTMLMediaElement::mediaPlayerScheduleLayerUpdate()
3978 { 3970 {
3979 scheduleLayerUpdate(); 3971 scheduleLayerUpdate();
3980 } 3972 }
3981 3973
3982 } 3974 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698