Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 22791003: Make media controls keyboard accessible

Created:
7 years, 4 months ago by Takeshi Kurosawa
Modified:
6 years, 4 months ago
Reviewers:
tkent, nessy
CC:
blink-reviews, eae+blinkwatch, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, David Tseng
Base URL:
http://src.chromium.org/blink/trunk/
Visibility:
Public.

Description

Make media controls keyboard accessible As media controls are implemented as shadow dom, media element is a shadow host. This patch makes media element keyboard focusable by removing HTMLMediaElement::hasCustomFocusLogic to make isNonKeyboardFocusableShadowHost and isKeyboardFocusableShadowHost return expected value. This patch also makes media element in standalone media document keyboad focusable. https://src.chromium.org/viewvc/blink?view=revision&revision=97367 removed keyboard support in standalone media document to avoid drawing focus ring by mouse click. However foucus by mouse click is disabled by https://src.chromium.org/viewvc/blink?view=revision&revision=106876. So, we don't need to disable keyboard focus. Contributed by taken.spc@gmail.com BUGS=135661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M LayoutTests/fast/events/media-focus-in-standalone-media-document.html View 2 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Takeshi Kurosawa
7 years, 4 months ago (2013-08-22 11:55:01 UTC) #1
tkent
I'm not sure if this is the expected behavior. The behavior of hasCustomFocusLogic==false is not ...
7 years, 4 months ago (2013-08-23 04:01:55 UTC) #2
tkent
+silviapf
7 years, 4 months ago (2013-08-26 00:25:18 UTC) #3
nessy
I'm not sure what a user should expect wrt focus ring from the video element. ...
7 years, 3 months ago (2013-08-26 10:57:13 UTC) #4
Takeshi Kurosawa
IE 10 let users to focus each control by pressing tab key as well as ...
7 years, 3 months ago (2013-08-26 14:04:22 UTC) #5
dmazzoni
Improving keyboard accessibility is great, but perhaps we should have a UI design review to ...
7 years, 3 months ago (2013-08-26 18:14:28 UTC) #6
David Tseng
+1; there's a lot we can do to improve the keyboard model. Some of the ...
7 years, 3 months ago (2013-08-26 21:15:01 UTC) #7
nessy
I agree with Dominic - create a short design doc for where you want to ...
7 years, 3 months ago (2013-08-27 22:33:15 UTC) #8
dmazzoni
6 years, 4 months ago (2014-08-11 05:41:27 UTC) #9

          

Powered by Google App Engine
This is Rietveld 408576698