Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2278983002:
Add resource whitelisting compatibility for offical builder scripts. (Closed)
|
Created:
4 years, 3 months ago by estevenson Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd resource whitelisting compatibility for offical builder scripts.
https://codereview.chromium.org/2272713004/ breaks
official builders so this CL ensures the offical build scripts work as
they used to.
BUG=640877
TBR=dpranke@chromium.org, brettw@chromium.org
Committed: https://crrev.com/76a9aecf54cd52327e4823e9aa81b53064c6362d
Cr-Commit-Position: refs/heads/master@{#414463}
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
estevenson@chromium.org changed reviewers: + dpranke@chromium.org
ptal!
Description was changed from ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640964 ========== to ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640964 TBR=dpranke@chromium.org ==========
The CQ bit was unchecked by estevenson@chromium.org
The CQ bit was checked by estevenson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640964 TBR=dpranke@chromium.org ========== to ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org ==========
lgtm
Description was changed from ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org ========== to ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org, brettw@chromium.org ==========
dpranke@chromium.org changed reviewers: + brettw@chromium.org
TBR'ing brettw@ for the chrome/BUILD.gn change.
The CQ bit was checked by estevenson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/25 16:46:29, Dirk Pranke wrote: > TBR'ing brettw@ for the chrome/BUILD.gn change. Thanks!
Message was sent while issue was closed.
Description was changed from ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org, brettw@chromium.org ========== to ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org, brettw@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org, brettw@chromium.org ========== to ========== Add resource whitelisting compatibility for offical builder scripts. https://codereview.chromium.org/2272713004/ breaks official builders so this CL ensures the offical build scripts work as they used to. BUG=640877 TBR=dpranke@chromium.org, brettw@chromium.org Committed: https://crrev.com/76a9aecf54cd52327e4823e9aa81b53064c6362d Cr-Commit-Position: refs/heads/master@{#414463} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/76a9aecf54cd52327e4823e9aa81b53064c6362d Cr-Commit-Position: refs/heads/master@{#414463} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
