Issue 22789002: file_manager: Rename and document some functions in file_manager_util.cc

Issue 22789002: file_manager: Rename and document some functions in file_manager_util.cc (Closed)

Created:
7 years, 4 months ago by satorux1

Modified:
7 years, 4 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Rename and document some functions in file_manager_util.cc Functions in file_manager_util.cc were poorly named and/or documented. Also simplify OpenFileWithFileBrowserHandler (was ExecuteExtensionHandler). BUG==270469 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216982

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -46 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.h	View		1 chunk	+16 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc	View	1	12 chunks	+65 lines, -41 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mtomasz

lgtm with a nit https://codereview.chromium.org/22789002/diff/4001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc File chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc (right): https://codereview.chromium.org/22789002/diff/4001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc#newcode414 chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc:414: // Some action IDs of ...

7 years, 4 months ago (2013-08-12 08:22:04 UTC) #2

satorux1

https://codereview.chromium.org/22789002/diff/4001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc File chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc (right): https://codereview.chromium.org/22789002/diff/4001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc#newcode414 chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc:414: // Some action IDs of the file manager's file ...

7 years, 4 months ago (2013-08-12 10:04:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/22789002/21001

7 years, 4 months ago (2013-08-12 10:07:50 UTC) #4

Message was sent while issue was closed.

Change committed as 216982

Expand Messages | Collapse Messages