Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 22789002: file_manager: Rename and document some functions in file_manager_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h"
6 6
7 #include "chrome/browser/chromeos/drive/drive_app_registry.h" 7 #include "chrome/browser/chromeos/drive/drive_app_registry.h"
8 #include "chrome/browser/chromeos/drive/drive_integration_service.h" 8 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
9 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handlers. h" 9 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handlers. h"
10 #include "chrome/browser/chromeos/extensions/file_manager/file_manager_util.h" 10 #include "chrome/browser/chromeos/extensions/file_manager/file_manager_util.h"
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 return false; 626 return false;
627 files.push_back(path); 627 files.push_back(path);
628 } 628 }
629 629
630 Browser* browser = chrome::FindOrCreateTabbedBrowser( 630 Browser* browser = chrome::FindOrCreateTabbedBrowser(
631 profile_, chrome::HOST_DESKTOP_TYPE_ASH); 631 profile_, chrome::HOST_DESKTOP_TYPE_ASH);
632 bool success = browser; 632 bool success = browser;
633 633
634 if (browser) { 634 if (browser) {
635 for (size_t i = 0; i < files.size(); ++i) { 635 for (size_t i = 0; i < files.size(); ++i) {
636 bool handled = util::ExecuteBuiltinHandler(browser, files[i]); 636 bool handled = util::OpenFileWithBrowser(browser, files[i]);
637 if (!handled && files.size() == 1) 637 if (!handled && files.size() == 1)
638 success = false; 638 success = false;
639 } 639 }
640 } 640 }
641 641
642 SetResult(Value::CreateBooleanValue(success)); 642 SetResult(Value::CreateBooleanValue(success));
643 SendResponse(true); 643 SendResponse(true);
644 return true; 644 return true;
645 } 645 }
646 646
647 } // namespace file_manager 647 } // namespace file_manager
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698