|
|
Created:
4 years, 3 months ago by Peter Kasting Modified:
4 years, 3 months ago Reviewers:
Dan Beam CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake bookmark URLs not float left in RTL.
Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.
BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506
Cr-Commit-Position: refs/heads/master@{#415464}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Wrong block #
Total comments: 1
Messages
Total messages: 21 (14 generated)
Description was changed from ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in RTL. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. ========== to ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in RTL. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by pkasting@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pkasting@chromium.org changed reviewers: + dbeam@chromium.org
Description was changed from ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in RTL. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in LTR. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo... File chrome/browser/resources/bookmark_manager/css/bmm.css (right): https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo... chrome/browser/resources/bookmark_manager/css/bmm.css:60: text-align: right; shouldn't we only be setting this in RTL?
The CQ bit was checked by pkasting@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo... File chrome/browser/resources/bookmark_manager/css/bmm.css (right): https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo... chrome/browser/resources/bookmark_manager/css/bmm.css:60: text-align: right; On 2016/08/29 16:35:47, Dan Beam wrote: > shouldn't we only be setting this in RTL? Yes... I have no explanation for this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2278413002/diff/20001/chrome/browser/resource... File chrome/browser/resources/bookmark_manager/css/bmm.css (right): https://codereview.chromium.org/2278413002/diff/20001/chrome/browser/resource... chrome/browser/resources/bookmark_manager/css/bmm.css:74: text-align: right; fun fact: there's an directionally adaptive, non-standard version[1] text-align: start; that would probably work for this. it aligns to the logical start (i.e. LTR => left, RTL => right). but there's really no reason to use it here because it's adding more rules to the common, LTR case. so lgtm [1] https://developer.mozilla.org/en-US/docs/Web/CSS/text-align
The CQ bit was checked by pkasting@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in LTR. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in LTR. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in LTR. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Make bookmark URLs not float left in RTL. Now they are positioned just after (i.e. left of) the bookmark labels, just like in LTR. BUG=none TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506 Cr-Commit-Position: refs/heads/master@{#415464} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506 Cr-Commit-Position: refs/heads/master@{#415464} |