Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2277293002: services/ui: Use the correct offset and stride in MojoGpuMemoryBuffer. (Closed)

Created:
4 years, 3 months ago by Peng
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Use the correct offset and stride in MojoGpuMemoryBuffer. BUG=None Committed: https://crrev.com/9286a11b8ef97363be868c378a6775c20d1e96f3 Cr-Commit-Position: refs/heads/master@{#414494}

Patch Set 1 #

Patch Set 2 : Fix build error. #

Total comments: 4

Patch Set 3 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M services/ui/public/cpp/mojo_gpu_memory_buffer.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer.cc View 1 2 7 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Peng
Hi Scott, PTAL. Thanks.
4 years, 3 months ago (2016-08-25 14:53:59 UTC) #2
sky
LGTM https://codereview.chromium.org/2277293002/diff/20001/services/ui/public/cpp/mojo_gpu_memory_buffer.h File services/ui/public/cpp/mojo_gpu_memory_buffer.h (right): https://codereview.chromium.org/2277293002/diff/20001/services/ui/public/cpp/mojo_gpu_memory_buffer.h#newcode46 services/ui/public/cpp/mojo_gpu_memory_buffer.h:46: MojoGpuMemoryBufferImpl(const gfx::Size& size, Move definition to match new ...
4 years, 3 months ago (2016-08-25 17:00:22 UTC) #9
Peng
https://codereview.chromium.org/2277293002/diff/20001/services/ui/public/cpp/mojo_gpu_memory_buffer.h File services/ui/public/cpp/mojo_gpu_memory_buffer.h (right): https://codereview.chromium.org/2277293002/diff/20001/services/ui/public/cpp/mojo_gpu_memory_buffer.h#newcode46 services/ui/public/cpp/mojo_gpu_memory_buffer.h:46: MojoGpuMemoryBufferImpl(const gfx::Size& size, On 2016/08/25 17:00:22, sky wrote: > ...
4 years, 3 months ago (2016-08-25 17:41:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277293002/40001
4 years, 3 months ago (2016-08-25 17:42:00 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-25 18:51:14 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:54:38 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9286a11b8ef97363be868c378a6775c20d1e96f3
Cr-Commit-Position: refs/heads/master@{#414494}

Powered by Google App Engine
This is Rietveld 408576698