Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2702)

Unified Diff: ash/common/wm/overview/window_selector.cc

Issue 2276853002: [ash-md] Does not cancel overview when focus shifts from text fitler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/overview/window_selector.cc
diff --git a/ash/common/wm/overview/window_selector.cc b/ash/common/wm/overview/window_selector.cc
index 2fcb7435b16bf485591a2aa3761f7d3f8ef0a47f..eda4fb055d758b9936c98558bda7627c66738b41 100644
--- a/ash/common/wm/overview/window_selector.cc
+++ b/ash/common/wm/overview/window_selector.cc
@@ -609,8 +609,12 @@ void WindowSelector::OnWindowActivated(WmWindow* gained_active,
auto iter = std::find_if(windows.begin(), windows.end(),
WindowSelectorItemTargetComparator(gained_active));
- if (iter != windows.end())
+ if (iter != windows.end()) {
(*iter)->ShowWindowOnExit();
+ } else if (showing_selection_widget_ &&
tdanderson 2016/08/24 14:49:25 What if the string entered into the text filter wi
varkha 2016/08/24 16:53:54 No. |showing_selection_widget_| is indicating visi
tdanderson 2016/08/24 17:43:52 Thanks.
+ lost_active == GetTextFilterWidgetWindow()) {
+ return;
+ }
// Don't restore focus on exit if a window was just activated.
ResetFocusRestoreWindow(false);
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | ash/wm/overview/window_selector_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698