[ash-md] Does not cancel overview when focus shifts from text fitler

ash/wm/overview/window_selector_unittest.cc

Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index b5d7c6fc872f3fb6b54fc7891aed365a4042acd7..dae94166085709321c1155124e8863b853ae5e4d 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -13,6 +13,7 @@
 #include "ash/common/shelf/shelf.h"
 #include "ash/common/shelf/shelf_widget.h"
 #include "ash/common/shell_window_ids.h"
+#include "ash/common/system/tray/system_tray.h"
 #include "ash/common/test/material_design_controller_test_api.h"
 #include "ash/common/wm/dock/docked_window_layout_manager.h"
 #include "ash/common/wm/maximize_mode/maximize_mode_controller.h"
@@ -1930,6 +1931,46 @@ TEST_P(WindowSelectorTest, TextFilteringSelection) {
   EXPECT_EQ(GetSelectedWindow(), window2.get());
 }
 
+// Tests that transferring focus from the text filter to a window that is not a
+// top level window does not cancel overview mode.
+TEST_P(WindowSelectorTest, ShowTextFilterMenu) {
+  gfx::Rect bounds(0, 0, 100, 100);
+  std::unique_ptr<aura::Window> window0(CreateWindow(bounds));
+  base::string16 window0_title = base::UTF8ToUTF16("Test");
+  window0->SetTitle(window0_title);
+  wm::GetWindowState(window0.get())->Minimize();
+  ToggleOverview();
+
+  EXPECT_FALSE(selection_widget_active());
+  EXPECT_FALSE(showing_filter_widget());
+  FilterItems("Test");
+
+  EXPECT_TRUE(selection_widget_active());
+  EXPECT_TRUE(showing_filter_widget());
+
+  // Open system bubble shifting focus from the text filter.

[tdanderson, 2016/08/24 14:49:25]

So what happens if you do the following?

1) Enter overview
2) Type something into the text filter
3) Open the system menu
4) Click on the Settings row to open WebUI settings in a new window

[varkha, 2016/08/24 16:53:54]

Activation of Settings WebUI window in step 4 will close overview so WAI.

[tdanderson, 2016/08/24 17:43:52]

Acknowledged.

+  SystemTray* tray = GetPrimarySystemTray();
+  tray->ShowDefaultView(BUBBLE_CREATE_NEW);
+  RunAllPendingInMessageLoop();
+
+  // This should not cancel overview mode.
+  ASSERT_TRUE(IsSelecting());
+  EXPECT_TRUE(selection_widget_active());
+  EXPECT_TRUE(showing_filter_widget());
+
+  // Click text filter to bring focus back.
+  ui::test::EventGenerator& generator = GetEventGenerator();
+  gfx::Point point_in_text_filter =
+      text_filter_widget()->GetWindowBoundsInScreen().CenterPoint();
+  generator.MoveMouseTo(point_in_text_filter);
+  generator.ClickLeftButton();
+  EXPECT_TRUE(IsSelecting());
+
+  // Cancel overview mode.
+  ToggleOverview();
+  ASSERT_FALSE(IsSelecting());
+}
+
 // Tests clicking on the desktop itself to cancel overview mode.
 TEST_P(WindowSelectorTest, CancelOverviewOnMouseClick) {
   // Overview disabled by default.