[Download Home] Add basic tests for the DownloadManagerUi

[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing the amount of space used.

BUG=616324
Committed: https://crrev.com/6d5d67418f54ce461fc7f4abb8e823fc987f3908
Cr-Commit-Position: refs/heads/master@{#413957}

[gone, 2016-08-23 18:00:44]

Description was changed from

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.

Tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

BUG=616324
==========

to

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing file sizes.

BUG=616324
==========

[gone, 2016-08-23 18:00:55]

Description was changed from

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing file sizes.

BUG=616324
==========

to

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing the amount of space used.

BUG=616324
==========

[gone, 2016-08-23 18:01:05]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2016-08-23 18:03:20]

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java
(left):

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java:331:
/** Converts a date string to a timestamp. */
Moved to StubbedProvider.

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
(right):

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java:225:
} else if (which == 6) {
Added two new items with large file sizes here.

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java:264:
} else if (which == 3) {
Added a gigantic Offline Page item.

[Theresa, 2016-08-23 20:52:21]

lgtm

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:132:
if (!downloadWrapper.hasBeenExternallyRemoved()) totalSize +=
wrapper.getFileSize();
On second thought, let's leave this to get the bug "fixed" before branch, then
I'll go in and clean it up w/ my CL for removing externally deleted items

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
(right):

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java:50:
public List<DownloadHistoryItemWrapper> onSelectionItems;
mOnSelectionItems?

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java:113:
@Restriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
nit: set the restriction above public class DownloadActivityTest...?

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java:216:
adapter.registerAdapterDataObserver(mAdapterObserver);
activity, ui, adapter and registerAdapterDataObserver seem to be needed for all
3 tests. Does it make sense to set them in setUp()

[gone, 2016-08-23 22:41:38]

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:132:
if (!downloadWrapper.hasBeenExternallyRemoved()) totalSize +=
wrapper.getFileSize();
On 2016/08/23 20:52:20, Theresa Wellington wrote:
> On second thought, let's leave this to get the bug "fixed" before branch, then
> I'll go in and clean it up w/ my CL for removing externally deleted items

Acknowledged.

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
(right):

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java:50:
public List<DownloadHistoryItemWrapper> onSelectionItems;
On 2016/08/23 20:52:20, Theresa Wellington wrote:
> mOnSelectionItems?

Done.

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java:113:
@Restriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
On 2016/08/23 20:52:20, Theresa Wellington wrote:
> nit: set the restriction above public class DownloadActivityTest...?

Done.

https://chromiumcodereview.appspot.com/2276633002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java:216:
adapter.registerAdapterDataObserver(mAdapterObserver);
On 2016/08/23 20:52:20, Theresa Wellington wrote:
> activity, ui, adapter and registerAdapterDataObserver seem to be needed for
all
> 3 tests. Does it make sense to set them in setUp()

Done.

[gone, 2016-08-23 22:41:44]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-23 22:41:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2276633002/#ps60001
(title: "Restrictions")

[commit-bot: I haz the power, 2016-08-23 22:42:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 00:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 00:04:39]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gone, 2016-08-24 00:09:53]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-24 00:10:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:30:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gone, 2016-08-24 01:34:31]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:35:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 02:53:26]

Description was changed from

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing the amount of space used.

BUG=616324
==========

to

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing the amount of space used.

BUG=616324
==========

[commit-bot: I haz the power, 2016-08-24 02:53:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 02:56:29]

Description was changed from

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing the amount of space used.

BUG=616324
==========

to

==========
[Download Home] Add basic tests for the DownloadManagerUi

Add tests that fire up the DownloadActivity on phones so that we can
test the DownloadManagerUi.  The tests added check for:
* Selecting/deleting multiple files
* Filtering items via the sidebar
* The space display being updated.

Also changes the DownloadHistoryAdapter to ignore deleted files
when computing the amount of space used.

BUG=616324

Committed: https://crrev.com/6d5d67418f54ce461fc7f4abb8e823fc987f3908
Cr-Commit-Position: refs/heads/master@{#413957}
==========

[commit-bot: I haz the power, 2016-08-24 02:56:30]

Patchset 4 (id:??) landed as
https://crrev.com/6d5d67418f54ce461fc7f4abb8e823fc987f3908
Cr-Commit-Position: refs/heads/master@{#413957}