[Download Home] Various fixes

[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
Committed: https://crrev.com/ff2f847b3e600d76f57f26edc1baec094dac7e67
Cr-Commit-Position: refs/heads/master@{#413976}

[gone, 2016-08-23 22:04:56]

dfalcantara@chromium.org changed reviewers:
+ qinmin@google.com, twellington@chromium.org

[gone, 2016-08-23 22:04:57]

Min for the changes to the DownloadManagerService launching the DownloadManager

Theresa for the other stuff

[gone, 2016-08-23 22:06:04]

Description was changed from

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

to

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

[gone, 2016-08-23 22:06:04]

Description was changed from

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

to

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

[Theresa, 2016-08-23 22:17:24]

lgtm % two nits

https://codereview.chromium.org/2269293002/diff/1/chrome/android/java/res/dra...
File chrome/android/java/res/drawable/material_progressbar.xml (right):

https://codereview.chromium.org/2269293002/diff/1/chrome/android/java/res/dra...
chrome/android/java/res/drawable/material_progressbar.xml:2: <!-- Copyright 2015
The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/2269293002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2269293002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:1084:
ChromeActivity chromeActivity = (ChromeActivity) lastActivity;
Do we want custom tabs to open our download manager? ChromeTabbedActivity?

[qinmin, 2016-08-23 22:26:13]

qinmin@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2016-08-23 22:26:13]

https://codereview.chromium.org/2269293002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2269293002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:1077:
boolean success = false;
No need for this variable, just early return if the lastActivity is
ChromeActivity, and remove the "if (!success)" condition.

[gone, 2016-08-23 23:04:58]

https://chromiumcodereview.appspot.com/2269293002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://chromiumcodereview.appspot.com/2269293002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:1077:
boolean success = false;
On 2016/08/23 22:26:13, qinmin wrote:
> No need for this variable, just early return if the lastActivity is
> ChromeActivity, and remove the "if (!success)" condition.
> 

Done.

https://chromiumcodereview.appspot.com/2269293002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:1084:
ChromeActivity chromeActivity = (ChromeActivity) lastActivity;
On 2016/08/23 22:17:24, Theresa Wellington wrote:
> Do we want custom tabs to open our download manager? ChromeTabbedActivity?

Only ChromeTabbedActivity, I guess.  Changed how Download Home is opened (from
webapps also) by changing DownloadUtils.

[gone, 2016-08-23 23:07:10]

https://chromiumcodereview.appspot.com/2269293002/diff/1/chrome/android/java/...
File chrome/android/java/res/drawable/material_progressbar.xml (right):

https://chromiumcodereview.appspot.com/2269293002/diff/1/chrome/android/java/...
chrome/android/java/res/drawable/material_progressbar.xml:2: <!-- Copyright 2015
The Chromium Authors. All rights reserved.
On 2016/08/23 22:17:24, Theresa Wellington wrote:
> 2016

WHAT YEAR IS IT

[gone, 2016-08-23 23:16:00]

Description was changed from

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

to

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity and as a dialog (for now) in other Activities.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

[qinmin, 2016-08-23 23:22:23]

lgtm

[gone, 2016-08-23 23:40:32]

Description was changed from

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity and as a dialog (for now) in other Activities.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

to

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

[gone, 2016-08-24 03:10:49]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-24 03:10:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, qinmin@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2269293002/#ps80001
(title: "Fullscreen activity")

[commit-bot: I haz the power, 2016-08-24 03:11:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 04:33:00]

Description was changed from

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

to

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

[commit-bot: I haz the power, 2016-08-24 04:33:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-24 04:35:00]

Description was changed from

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324
==========

to

==========
[Download Home] Various fixes

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324

Committed: https://crrev.com/ff2f847b3e600d76f57f26edc1baec094dac7e67
Cr-Commit-Position: refs/heads/master@{#413976}
==========

[commit-bot: I haz the power, 2016-08-24 04:35:03]

Patchset 5 (id:??) landed as
https://crrev.com/ff2f847b3e600d76f57f26edc1baec094dac7e67
Cr-Commit-Position: refs/heads/master@{#413976}