Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc

Issue 2276353002: Remove after wakeup logic and replace PumpTask with Fences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Slight simplification Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc b/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
index 2ef59ae61e9798975adf9bdba3c78d5483a84010..87d4192c2b95b34fb7ce250ce63bddd48b6b1434 100644
--- a/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
@@ -171,21 +171,6 @@ TEST_F(SchedulerHelperTest, ObserversNotNotifiedFor_ControlTaskRunner) {
RunUntilIdle();
}
-TEST_F(SchedulerHelperTest,
- ObserversNotNotifiedFor_ControlAfterWakeUpTaskRunner) {
- MockTaskObserver observer;
- scheduler_helper_->AddTaskObserver(&observer);
-
- scheduler_helper_->ControlAfterWakeUpTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&NopTask));
-
- EXPECT_CALL(observer, WillProcessTask(_)).Times(0);
- EXPECT_CALL(observer, DidProcessTask(_)).Times(0);
- LazyNow lazy_now(clock_.get());
- scheduler_helper_->ControlAfterWakeUpTaskRunner()->PumpQueue(&lazy_now, true);
- RunUntilIdle();
-}
-
namespace {
class MockObserver : public SchedulerHelper::Observer {
@@ -220,6 +205,11 @@ TEST_F(SchedulerHelperTest, OnTriedToExecuteBlockedTask) {
task_queue->SetQueueEnabled(false);
task_queue->PostTask(FROM_HERE, base::Bind(&NopTask));
+ // Trick |task_queue| into posting a DoWork. By default PostTask with a
+ // disabled queue won't post a DoWork until we enable the queue.
+ task_queue->SetQueueEnabled(true);
+ task_queue->SetQueueEnabled(false);
+
EXPECT_CALL(observer, OnTriedToExecuteBlockedTask(_, _)).Times(1);
RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698