Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc

Issue 2276353002: Remove after wakeup logic and replace PumpTask with Fences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Slight simplification Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc b/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
index dfb50c313f946d1d1e3549b3ba268f3147b8d4da..b6df36b69d1396c1047b907738f14b20ded1e693 100644
--- a/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
+++ b/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
@@ -13,19 +13,15 @@ namespace scheduler {
SingleThreadIdleTaskRunner::SingleThreadIdleTaskRunner(
scoped_refptr<base::SingleThreadTaskRunner> idle_priority_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> after_wakeup_task_runner,
Delegate* delegate,
const char* tracing_category)
: idle_priority_task_runner_(idle_priority_task_runner),
- after_wakeup_task_runner_(after_wakeup_task_runner),
delegate_(delegate),
tracing_category_(tracing_category),
blame_context_(nullptr),
weak_factory_(this) {
DCHECK(!idle_priority_task_runner_ ||
idle_priority_task_runner_->RunsTasksOnCurrentThread());
- DCHECK(!after_wakeup_task_runner_ ||
- after_wakeup_task_runner_->RunsTasksOnCurrentThread());
weak_scheduler_ptr_ = weak_factory_.GetWeakPtr();
}
@@ -57,16 +53,6 @@ void SingleThreadIdleTaskRunner::PostNonNestableIdleTask(
weak_scheduler_ptr_, idle_task));
}
-void SingleThreadIdleTaskRunner::PostIdleTaskAfterWakeup(
- const tracked_objects::Location& from_here,
- const IdleTask& idle_task) {
- // Don't signal posting of idle task to the delegate here, wait until the
- // after-wakeup task posts the real idle task.
- after_wakeup_task_runner_->PostTask(
- FROM_HERE, base::Bind(&SingleThreadIdleTaskRunner::PostIdleTask,
- weak_scheduler_ptr_, from_here, idle_task));
-}
-
void SingleThreadIdleTaskRunner::RunTask(IdleTask idle_task) {
base::TimeTicks deadline = delegate_->WillProcessIdleTask();
TRACE_EVENT1(tracing_category_, "SingleThreadIdleTaskRunner::RunTask",

Powered by Google App Engine
This is Rietveld 408576698