Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain.cc

Issue 2276353002: Remove after wakeup logic and replace PumpTask with Fences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Slight simplification Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc b/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
index 3e86ec3c0da314a13ac946600df7c6cad39acaa8..5837384e776dbb4f8e12d192a063927f9f2c2550 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
@@ -151,14 +151,11 @@ bool TimeDomain::UnregisterAsUpdatableTaskQueue(
return was_updatable;
}
-void TimeDomain::UpdateWorkQueues(
- bool should_trigger_wakeup,
- const internal::TaskQueueImpl::Task* previous_task,
- LazyNow lazy_now) {
+void TimeDomain::UpdateWorkQueues(LazyNow lazy_now) {
DCHECK(main_thread_checker_.CalledOnValidThread());
// Move any ready delayed tasks into the Incoming queues.
- WakeupReadyDelayedQueues(&lazy_now, should_trigger_wakeup, previous_task);
+ WakeupReadyDelayedQueues(&lazy_now);
MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
@@ -169,7 +166,7 @@ void TimeDomain::UpdateWorkQueues(
// This is fine, erasing an element won't invalidate any interator, as long
// as the iterator isn't the element being delated.
if (queue->immediate_work_queue()->Empty())
- queue->UpdateImmediateWorkQueue(should_trigger_wakeup, previous_task);
+ queue->UpdateImmediateWorkQueue();
}
}
@@ -182,10 +179,7 @@ void TimeDomain::MoveNewlyUpdatableQueuesIntoUpdatableQueueSet() {
}
}
-void TimeDomain::WakeupReadyDelayedQueues(
- LazyNow* lazy_now,
- bool should_trigger_wakeup,
- const internal::TaskQueueImpl::Task* previous_task) {
+void TimeDomain::WakeupReadyDelayedQueues(LazyNow* lazy_now) {
DCHECK(main_thread_checker_.CalledOnValidThread());
// Wake up any queues with pending delayed work. Note std::multipmap stores
// the elements sorted by key, so the begin() iterator points to the earliest
@@ -202,8 +196,7 @@ void TimeDomain::WakeupReadyDelayedQueues(
// in which EnqueueTaskLocks is called is respected when choosing which
// queue to execute a task from.
if (dedup_set.insert(next_wakeup->second).second) {
- next_wakeup->second->UpdateDelayedWorkQueue(
- lazy_now, should_trigger_wakeup, previous_task);
+ next_wakeup->second->UpdateDelayedWorkQueue(lazy_now);
}
delayed_wakeup_multimap_.erase(next_wakeup);
}

Powered by Google App Engine
This is Rietveld 408576698