third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc - Issue 2276353002: Remove after wakeup logic and replace PumpTask with Fences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2276353002: Remove after wakeup logic and replace PumpTask with Fences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Slight simplification Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/time_domain.cc ('k') | third_party/WebKit/Source/platform/scheduler/base/work_queue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

index 69023fd7a9553ee40a298db323682382edcb08fd..610b95b304f5838222707ad1153108d352959a3d 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

@@ -161,13 +161,13 @@ TEST_F(TimeDomainTest, UpdateWorkQueues) {

EXPECT_EQ(delayed_runtime, next_run_time);

LazyNow lazy_now = time_domain_->CreateLazyNow();

- time_domain_->UpdateWorkQueues(false, nullptr, lazy_now);

+ time_domain_->UpdateWorkQueues(lazy_now);

ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));

EXPECT_EQ(delayed_runtime, next_run_time);

time_domain_->SetNow(delayed_runtime);

lazy_now = time_domain_->CreateLazyNow();

- time_domain_->UpdateWorkQueues(false, nullptr, lazy_now);

+ time_domain_->UpdateWorkQueues(lazy_now);

ASSERT_FALSE(time_domain_->NextScheduledRunTime(&next_run_time));

}

@@ -270,7 +270,7 @@ TEST_F(TimeDomainTest, CancelDelayedWorkTwoWakeUpsCancelSecond) {

time_domain_->SetNow(delayed_runtime1);

LazyNow lazy_now = time_domain_->CreateLazyNow();

- time_domain_->UpdateWorkQueues(false, nullptr, lazy_now);

+ time_domain_->UpdateWorkQueues(lazy_now);

ASSERT_FALSE(time_domain_->NextScheduledRunTime(&next_run_time));

}