Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 22731002: Improve style of JWK serializer (Closed)

Created:
7 years, 4 months ago by juanlang
Modified:
7 years, 4 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve style of JWK serializer BUG=259097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M net/cert/jwk_serializer_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/jwk_serializer_openssl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/jwk_serializer_unittest.cc View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
juanlang
Hi Wan-Teh, this addresses the style feedback you gave me on https://chromiumcodereview.appspot.com/21561003/. I don't know ...
7 years, 4 months ago (2013-08-09 04:58:41 UTC) #1
wtc
Patch set 1 LGTM. Thanks. Do you need me to submit this CL to the ...
7 years, 4 months ago (2013-08-09 17:22:51 UTC) #2
juanlang
On 2013/08/09 17:22:51, wtc wrote: > Patch set 1 LGTM. Thanks. > > Do you ...
7 years, 4 months ago (2013-08-09 17:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@google.com/22731002/1
7 years, 4 months ago (2013-08-09 17:23:33 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186058
7 years, 4 months ago (2013-08-10 03:15:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@google.com/22731002/1
7 years, 4 months ago (2013-08-10 03:59:00 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 14:19:10 UTC) #7
Message was sent while issue was closed.
Change committed as 216852

Powered by Google App Engine
This is Rietveld 408576698