Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: net/cert/jwk_serializer_unittest.cc

Issue 22731002: Improve style of JWK serializer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/jwk_serializer_openssl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/jwk_serializer_unittest.cc
diff --git a/net/cert/jwk_serializer_unittest.cc b/net/cert/jwk_serializer_unittest.cc
index 37b80029516f60c014658b576f20fcfc68dec94f..8059e73a3a6915916dd55f0a8b7d26be6138d2a6 100644
--- a/net/cert/jwk_serializer_unittest.cc
+++ b/net/cert/jwk_serializer_unittest.cc
@@ -26,7 +26,7 @@ static const unsigned char kP256SpkiPrefix[] = {
0x86, 0x48, 0xce, 0x3d, 0x03, 0x01, 0x07, 0x03,
0x42, 0x00, 0x04
};
-static const unsigned int kEcPointSize = 32U;
+static const unsigned int kEcCoordinateSize = 32U;
// This is a valid P-256 public key.
static const unsigned char kSpkiEc[] = {
@@ -82,19 +82,19 @@ TEST(JwkSerializerNSSTest, ConvertSpkiFromDerToJwkEc) {
EXPECT_TRUE(public_key_jwk.GetString("x", &string_value));
std::string decoded_coordinate;
EXPECT_TRUE(base::Base64Decode(string_value, &decoded_coordinate));
- EXPECT_EQ(kEcPointSize, decoded_coordinate.size());
+ EXPECT_EQ(kEcCoordinateSize, decoded_coordinate.size());
EXPECT_EQ(0,
memcmp(decoded_coordinate.data(),
kSpkiEc + sizeof(kP256SpkiPrefix),
- kEcPointSize));
+ kEcCoordinateSize));
EXPECT_TRUE(public_key_jwk.GetString("y", &string_value));
EXPECT_TRUE(base::Base64Decode(string_value, &decoded_coordinate));
- EXPECT_EQ(kEcPointSize, decoded_coordinate.size());
+ EXPECT_EQ(kEcCoordinateSize, decoded_coordinate.size());
EXPECT_EQ(0,
memcmp(decoded_coordinate.data(),
- kSpkiEc + sizeof(kP256SpkiPrefix) + kEcPointSize,
- kEcPointSize));
+ kSpkiEc + sizeof(kP256SpkiPrefix) + kEcCoordinateSize,
+ kEcCoordinateSize));
// Test the result of a corner case: leading 0s in the x, y coordinates are
// not trimmed, but the point is fixed-length encoded.
@@ -109,19 +109,19 @@ TEST(JwkSerializerNSSTest, ConvertSpkiFromDerToJwkEc) {
EXPECT_TRUE(public_key_jwk.GetString("x", &string_value));
EXPECT_TRUE(base::Base64Decode(string_value, &decoded_coordinate));
- EXPECT_EQ(kEcPointSize, decoded_coordinate.size());
+ EXPECT_EQ(kEcCoordinateSize, decoded_coordinate.size());
EXPECT_EQ(0,
memcmp(decoded_coordinate.data(),
kSpkiEcWithZeroXY + sizeof(kP256SpkiPrefix),
- kEcPointSize));
+ kEcCoordinateSize));
EXPECT_TRUE(public_key_jwk.GetString("y", &string_value));
EXPECT_TRUE(base::Base64Decode(string_value, &decoded_coordinate));
- EXPECT_EQ(kEcPointSize, decoded_coordinate.size());
+ EXPECT_EQ(kEcCoordinateSize, decoded_coordinate.size());
EXPECT_EQ(0,
- memcmp(decoded_coordinate.data(),
- kSpkiEcWithZeroXY + sizeof(kP256SpkiPrefix) + kEcPointSize,
- kEcPointSize));
+ memcmp(decoded_coordinate.data(),
+ kSpkiEcWithZeroXY + sizeof(kP256SpkiPrefix) + kEcCoordinateSize,
+ kEcCoordinateSize));
}
#else
« no previous file with comments | « net/cert/jwk_serializer_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698