chrome/browser/resources/settings/settings_shared_css.html - Issue 2273083002: [MD settings] using h2 for sub-headers consistently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2273083002: [MD settings] using h2 for sub-headers consistently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('K') | « chrome/browser/resources/settings/settings_page/settings_subpage.html ('k') | chrome/browser/resources/settings/settings_ui/settings_ui.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_shared_css.html

diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html

index 0d55ef3788c67593b0055c1f6cf210aaf209363c..3cb7fb847908be11aeee24446be49829b74fe538 100644

--- a/chrome/browser/resources/settings/settings_shared_css.html

+++ b/chrome/browser/resources/settings/settings_shared_css.html

@@ -5,13 +5,16 @@

<dom-module id="settings-shared">

+ /* Use <h2> as the "sub-header" mentioned in the UX design docs. */

h2 {

align-items: center;

+ color: var(--paper-grey-600);

display: flex;

- font-size: 100%;

+ font-size: inherit;

font-weight: 500;

margin: 0;

- min-height: var(--settings-row-min-height);

+ padding-top: 24px;

+ padding-bottom: 12px;

}

iron-icon[icon='cr:check'],