Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2297)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2273083002: [MD settings] using h2 for sub-headers consistently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index 90e3a12d1e2ac8a3f839332498593ae3e1626206..04b512eebc781843f34b633530c2b6d12a1b9634 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -15,10 +15,6 @@
<link rel="import" type="css" href="chrome://resources/css/action_link.css">
<template>
<style include="settings-shared passwords-shared">
- #manageLink {
- margin-bottom: 24px;
- }
-
#password {
background-color: transparent;
border: none;
@@ -27,10 +23,6 @@
width: 0;
}
- #autosigninCheckbox {
- margin-bottom: 24px;
- }
-
.website-column {
flex: 3;
}
@@ -55,14 +47,21 @@
@apply(--settings-actionable);
}
</style>
- <settings-checkbox id="autosigninCheckbox"
- pref="{{prefs.credentials_enable_autosignin}}"
- label="$i18n{passwordsAutosigninLabel}"
- sub-label="$i18n{passwordsAutosigninDescription}">
- </settings-checkbox>
- <div id="manageLink">$i18nRaw{managePasswordsLabel}</div>
- <div class="heading">$i18n{savedPasswordsHeading}</div>
- <div class="item-list" scrollable>
+ <div class="settings-box first two-line">
Dan Beam 2017/01/10 22:28:01 why is this two-line?
dschuyler 2017/01/10 22:54:40 Likely for the sub-label="". It may be nicer if th
Dan Beam 2017/01/10 22:58:55 connected to the contents like this? https://cs.ch
dschuyler 2017/01/10 23:05:19 Like that, yes.
+ <settings-checkbox id="autosigninCheckbox"
+ pref="{{prefs.credentials_enable_autosignin}}"
+ label="$i18n{passwordsAutosigninLabel}"
+ sub-label="$i18n{passwordsAutosigninDescription}">
+ </settings-checkbox>
+ </div>
+ <div id="manageLink" class="settings-box first">
+ <!-- This span lays out the url correctly, relative to the label. -->
+ <span>$i18nRaw{managePasswordsLabel}</span>
+ </div>
+ <div class="settings-box first">
+ <h2>$i18n{savedPasswordsHeading}</h2>
+ </div>
+ <div class="list-frame" scrollable>
<div class="list-item column-header">
<div class="website-column">$i18n{editPasswordWebsiteLabel}</div>
<div class="username-column">
@@ -74,7 +73,7 @@
</div>
<iron-list id="passwordList"
items="[[getFilteredPasswords_(savedPasswords, filter)]]"
- class="vertical-list list-section list-with-header">
+ class="vertical-list list-with-header">
<template>
<div class="list-item">
<div class="website-column">
@@ -109,9 +108,10 @@
item="[[activePassword]]">
</password-edit-dialog>
</template>
- <div class="heading">$i18n{passwordExceptionsHeading}</div>
- <div id="passwordExceptionsList"
- class="vertical-list list-section item-list">
+ <div class="settings-box block first">
+ <h2>$i18n{passwordExceptionsHeading}</h2>
+ </div>
+ <div id="passwordExceptionsList" class="list-frame vertical-list">
<template is="dom-repeat" items="[[passwordExceptions]]"
filter="[[passwordExceptionFilter_(filter)]]">
<div class="list-item two-line">

Powered by Google App Engine
This is Rietveld 408576698