Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2267283002: media: Separate renewal from default External Clear Key test (Closed)

Created:
4 years, 4 months ago by xhwang
Modified:
4 years, 3 months ago
Reviewers:
*jrummell, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, eme-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Separate renewal from default External Clear Key test External Clear Key should be an external "Clear Key" key system which behaves the same as "Clear Key" but is hosted externally (e.g. in a separate process). It could support decrypt-and-decode by incorporating codecs, or only support decrypt-only (same as default Clear Key implementation in Chromium). This will help us enable External Clear Key tests on multiple platforms, e.g. on Android. To do this, we need to move non-standard "Clear Key" features out of the default External Clear Key test. This CL moves "renewal" test to a new key system name: org.chromium.externalclearkey.renewal. BUG=581893 TEST=This CL splits a curent test into two tests. Committed: https://crrev.com/0cfb52830075ed187d67ddc41e4edd3bd828355e Cr-Commit-Position: refs/heads/master@{#414291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M media/test/data/eme_player.html View 1 chunk +7 lines, -9 lines 0 comments Download
M media/test/data/eme_player_js/globals.js View 1 chunk +2 lines, -1 line 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 1 chunk +2 lines, -1 line 0 comments Download
M media/test/data/eme_player_js/utils.js View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
xhwang
PTAL
4 years, 4 months ago (2016-08-23 01:10:46 UTC) #6
jrummell
lgtm
4 years, 4 months ago (2016-08-24 20:40:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267283002/1
4 years, 4 months ago (2016-08-24 23:17:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/252330)
4 years, 4 months ago (2016-08-25 01:20:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267283002/1
4 years, 3 months ago (2016-08-25 03:18:14 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 03:34:03 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:37:26 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cfb52830075ed187d67ddc41e4edd3bd828355e
Cr-Commit-Position: refs/heads/master@{#414291}

Powered by Google App Engine
This is Rietveld 408576698