Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: dm/api/distributor/swarming/v1/params.proto

Issue 2267143002: Add additional validation to swarming v1 distributor. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@dump_all_stacks
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dm/api/distributor/swarming/v1/params.proto
diff --git a/dm/api/distributor/swarming/v1/params.proto b/dm/api/distributor/swarming/v1/params.proto
index dff6dd121026f58eb6ecb886cd223ba1e532eaf3..e806d807c7dd0d6c0dbcebf55f4e0d92b71c2a93 100644
--- a/dm/api/distributor/swarming/v1/params.proto
+++ b/dm/api/distributor/swarming/v1/params.proto
@@ -66,8 +66,10 @@ message Parameters {
// 0 or more cipd packages for the job.
repeated CipdPackage packages = 2;
- // Optional server to use for cipd packages. If you know you're using
- // swarming's default server, you can omit this.
+ // Server to use for cipd packages. Required (though it may be specified
+ // by the quest's designated distributor config). This must be
+ // scheme://<hostname>, e.g. "https://example.appspot.com". The only
+ // supported schemes are http and https.
string cipd_server = 3;
}
Inputs inputs = 1;

Powered by Google App Engine
This is Rietveld 408576698