dm/api/distributor/swarming/v1/params.pb.go - Issue 2267143002: Add additional validation to swarming v1 distributor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/api/distributor/swarming/v1/params.pb.go

Issue 2267143002: Add additional validation to swarming v1 distributor. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@dump_all_stacks

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dm/api/distributor/swarming/v1/normalize.go ('K') | « dm/api/distributor/swarming/v1/params.proto ('k') | dm/appengine/distributor/swarming/v1/distributor.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dm/api/distributor/swarming/v1/params.pb.go

diff --git a/dm/api/distributor/swarming/v1/params.pb.go b/dm/api/distributor/swarming/v1/params.pb.go

index 14f1d8d712b08ea088b960911c4598f6f7ece689..84343870e767a3c8370b61d42ac56c64228c3adf 100644

--- a/dm/api/distributor/swarming/v1/params.pb.go

+++ b/dm/api/distributor/swarming/v1/params.pb.go

@@ -157,8 +157,10 @@ type Parameters_Job_Inputs struct {

Isolated []*IsolatedRef `protobuf:"bytes,1,rep,name=isolated" json:"isolated,omitempty"`

// 0 or more cipd packages for the job.

Packages []*Parameters_Job_Inputs_CipdPackage `protobuf:"bytes,2,rep,name=packages" json:"packages,omitempty"`

- // Optional server to use for cipd packages. If you know you're using

- // swarming's default server, you can omit this.

+ // Server to use for cipd packages. Required (though it may be specified

+ // by the quest's designated distributor config). This must be

+ // scheme://<hostname>, e.g. "https://example.appspot.com". The only

+ // supported schemes are http and https.

CipdServer string `protobuf:"bytes,3,opt,name=cipd_server,json=cipdServer" json:"cipd_server,omitempty"`

}