Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4793)

Unified Diff: chrome/browser/previews/previews_infobar_delegate.cc

Issue 2266653002: Previews infobar tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddUMA
Patch Set: bengr comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_delegate.cc
diff --git a/chrome/browser/previews/previews_infobar_delegate.cc b/chrome/browser/previews/previews_infobar_delegate.cc
index 2390e8cada6fa22b2636d3bc81d7eb3f13263837..275811a4a1cf47db5412207bee0ff20c2beec63c 100644
--- a/chrome/browser/previews/previews_infobar_delegate.cc
+++ b/chrome/browser/previews/previews_infobar_delegate.cc
@@ -29,28 +29,18 @@ const char kUMAPreviewsInfoBarActionOffline[] =
const char kUMAPreviewsInfoBarActionLitePage[] =
"Previews.InfoBarAction.LitePage";
-// Actions on the previews infobar. This enum must remain synchronized with the
-// enum of the same name in metrics/histograms/histograms.xml.
-enum PreviewsInfoBarAction {
- INFOBAR_SHOWN = 0,
- INFOBAR_LOAD_ORIGINAL_CLICKED = 1,
- INFOBAR_DISMISSED_BY_USER = 2,
- INFOBAR_DISMISSED_BY_NAVIGATION = 3,
- INFOBAR_INDEX_BOUNDARY
-};
-
void RecordPreviewsInfoBarAction(
PreviewsInfoBarDelegate::PreviewsInfoBarType infobar_type,
- PreviewsInfoBarAction action) {
+ PreviewsInfoBarDelegate::PreviewsInfoBarAction action) {
if (infobar_type == PreviewsInfoBarDelegate::LOFI) {
UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionLoFi, action,
- INFOBAR_INDEX_BOUNDARY);
+ PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
} else if (infobar_type == PreviewsInfoBarDelegate::LITE_PAGE) {
UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionLitePage, action,
- INFOBAR_INDEX_BOUNDARY);
+ PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
} else if (infobar_type == PreviewsInfoBarDelegate::OFFLINE) {
UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionOffline, action,
- INFOBAR_INDEX_BOUNDARY);
+ PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
}
}
« no previous file with comments | « chrome/browser/previews/previews_infobar_delegate.h ('k') | chrome/browser/previews/previews_infobar_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698