Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5751)

Unified Diff: chrome/browser/previews/previews_infobar_delegate_unittest.cc

Issue 2266653002: Previews infobar tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddUMA
Patch Set: bengr comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_delegate_unittest.cc
diff --git a/chrome/browser/previews/previews_infobar_delegate_unittest.cc b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..77a60dbb5bb9d184b4840481f6c7c8307ed7a7d1
--- /dev/null
+++ b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
@@ -0,0 +1,252 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/previews/previews_infobar_delegate.h"
+
+#include <memory>
+
+#include "base/test/histogram_tester.h"
+#include "chrome/browser/android/android_theme_resources.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
+#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
+#include "chrome/browser/previews/previews_infobar_tab_helper.h"
+#include "chrome/grit/generated_resources.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"
+#include "components/infobars/core/infobar.h"
+#include "components/infobars/core/infobar_delegate.h"
+#include "components/prefs/pref_registry_simple.h"
+#include "components/proxy_config/proxy_config_pref_names.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/web_contents_tester.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/window_open_disposition.h"
+
+namespace {
+
+const char kTestUrl[] = "http://www.test.com/";
+
+// Key of the UMA Previews.InfoBarAction.LoFi histogram.
+const char kUMAPreviewsInfoBarActionLoFi[] = "Previews.InfoBarAction.LoFi";
+
+// Key of the UMA Previews.InfoBarAction.Offline histogram.
+const char kUMAPreviewsInfoBarActionOffline[] =
+ "Previews.InfoBarAction.Offline";
+
+// Key of the UMA Previews.InfoBarAction.LitePage histogram.
+const char kUMAPreviewsInfoBarActionLitePage[] =
+ "Previews.InfoBarAction.LitePage";
+
+} // namespace
+
+class PreviewsInfoBarDelegateUnitTest : public ChromeRenderViewHostTestHarness {
+ protected:
+ void SetUp() override {
+ ChromeRenderViewHostTestHarness::SetUp();
+ InfoBarService::CreateForWebContents(web_contents());
+ PreviewsInfoBarTabHelper::CreateForWebContents(web_contents());
+
+ drp_test_context_ =
+ data_reduction_proxy::DataReductionProxyTestContext::Builder()
+ .WithMockConfig()
+ .SkipSettingsInitialization()
+ .Build();
+
+ auto* data_reduction_proxy_settings =
+ DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
+ web_contents()->GetBrowserContext());
+
+ PrefRegistrySimple* registry =
+ drp_test_context_->pref_service()->registry();
+ registry->RegisterDictionaryPref(proxy_config::prefs::kProxy);
+ data_reduction_proxy_settings
+ ->set_data_reduction_proxy_enabled_pref_name_for_test(
+ drp_test_context_->GetDataReductionProxyEnabledPrefName());
+ data_reduction_proxy_settings->InitDataReductionProxySettings(
+ drp_test_context_->io_data(), drp_test_context_->pref_service(),
+ drp_test_context_->request_context_getter(),
+ base::WrapUnique(new data_reduction_proxy::DataStore()),
+ base::ThreadTaskRunnerHandle::Get(),
+ base::ThreadTaskRunnerHandle::Get());
+ }
+
+ void TearDown() override {
+ drp_test_context_->DestroySettings();
+ ChromeRenderViewHostTestHarness::TearDown();
+ }
+
+ ConfirmInfoBarDelegate* CreateInfoBar(
+ PreviewsInfoBarDelegate::PreviewsInfoBarType type) {
+ PreviewsInfoBarDelegate::Create(web_contents(), type);
+
+ InfoBarService* infobar_service =
+ InfoBarService::FromWebContents(web_contents());
+ EXPECT_EQ(1U, infobar_service->infobar_count());
+
+ return infobar_service->infobar_at(0)
+ ->delegate()
+ ->AsConfirmInfoBarDelegate();
+ }
+
+ InfoBarService* infobar_service() {
+ return InfoBarService::FromWebContents(web_contents());
+ }
+
+ std::unique_ptr<data_reduction_proxy::DataReductionProxyTestContext>
+ drp_test_context_;
+};
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestNavigationDismissal) {
+ base::HistogramTester tester;
+
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+
+ // Try showing a second infobar. Another should not be shown since the page
+ // has not navigated.
+ PreviewsInfoBarDelegate::Create(web_contents(),
+ PreviewsInfoBarDelegate::LOFI);
+ EXPECT_EQ(1U, infobar_service()->infobar_count());
+
+ // Navigate and make sure the infobar is dismissed.
+ content::WebContentsTester::For(web_contents())
+ ->NavigateAndCommit(GURL(kTestUrl));
+ EXPECT_EQ(0U, infobar_service()->infobar_count());
+
+ tester.ExpectBucketCount(
+ kUMAPreviewsInfoBarActionLoFi,
+ PreviewsInfoBarDelegate::INFOBAR_DISMISSED_BY_NAVIGATION, 1);
+ EXPECT_EQ(0, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiLoadImagesPerSession));
+}
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestUserDismissal) {
+ base::HistogramTester tester;
+
+ ConfirmInfoBarDelegate* infobar =
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+
+ // Simulate dismissing the infobar.
+ infobar->InfoBarDismissed();
+ infobar_service()->infobar_at(0)->RemoveSelf();
+ EXPECT_EQ(0U, infobar_service()->infobar_count());
+
+ tester.ExpectBucketCount(kUMAPreviewsInfoBarActionLoFi,
+ PreviewsInfoBarDelegate::INFOBAR_DISMISSED_BY_USER,
+ 1);
+ EXPECT_EQ(0, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiLoadImagesPerSession));
+}
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestClickLink) {
+ base::HistogramTester tester;
+
+ ConfirmInfoBarDelegate* infobar =
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+
+ // Simulate clicking the infobar link.
+ if (infobar->LinkClicked(WindowOpenDisposition::CURRENT_TAB))
+ infobar_service()->infobar_at(0)->RemoveSelf();
+ EXPECT_EQ(0U, infobar_service()->infobar_count());
+
+ tester.ExpectBucketCount(
+ kUMAPreviewsInfoBarActionLoFi,
+ PreviewsInfoBarDelegate::INFOBAR_LOAD_ORIGINAL_CLICKED, 1);
+ EXPECT_EQ(1, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiLoadImagesPerSession));
+}
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestShownOncePerNavigation) {
+ ConfirmInfoBarDelegate* infobar =
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+
+ // Simulate dismissing the infobar.
+ infobar->InfoBarDismissed();
+ infobar_service()->infobar_at(0)->RemoveSelf();
+ EXPECT_EQ(0U, infobar_service()->infobar_count());
+
+ PreviewsInfoBarDelegate::Create(web_contents(),
+ PreviewsInfoBarDelegate::LOFI);
+
+ // Infobar should not be shown again since a navigation hasn't happened.
+ EXPECT_EQ(0U, infobar_service()->infobar_count());
+
+ // Navigate and show infobar again.
+ content::WebContentsTester::For(web_contents())
+ ->NavigateAndCommit(GURL(kTestUrl));
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+}
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, LoFiInfobarTest) {
+ base::HistogramTester tester;
+
+ ConfirmInfoBarDelegate* infobar =
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+
+ tester.ExpectUniqueSample(kUMAPreviewsInfoBarActionLoFi,
+ PreviewsInfoBarDelegate::INFOBAR_SHOWN, 1);
+ EXPECT_EQ(1, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiUIShownPerSession));
+
+ ASSERT_TRUE(infobar);
+ ASSERT_EQ(l10n_util::GetStringUTF16(IDS_PREVIEWS_INFOBAR_SAVED_DATA_TITLE),
+ infobar->GetMessageText());
+ ASSERT_EQ(l10n_util::GetStringUTF16(IDS_PREVIEWS_INFOBAR_LINK),
+ infobar->GetLinkText());
+#if defined(OS_ANDROID)
+ ASSERT_EQ(IDR_ANDROID_INFOBAR_PREVIEWS, infobar->GetIconId());
+#else
+ ASSERT_EQ(PreviewsInfoBarDelegate::kNoIconID, infobar->GetIconId());
+#endif
+}
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, PreviewInfobarTest) {
+ base::HistogramTester tester;
+
+ ConfirmInfoBarDelegate* infobar =
+ CreateInfoBar(PreviewsInfoBarDelegate::LITE_PAGE);
+
+ tester.ExpectUniqueSample(kUMAPreviewsInfoBarActionLitePage,
+ PreviewsInfoBarDelegate::INFOBAR_SHOWN, 1);
+ EXPECT_EQ(1, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiUIShownPerSession));
+
+ // Check the strings.
+ ASSERT_TRUE(infobar);
+ ASSERT_EQ(l10n_util::GetStringUTF16(IDS_PREVIEWS_INFOBAR_SAVED_DATA_TITLE),
+ infobar->GetMessageText());
+ ASSERT_EQ(l10n_util::GetStringUTF16(IDS_PREVIEWS_INFOBAR_LINK),
+ infobar->GetLinkText());
+#if defined(OS_ANDROID)
+ ASSERT_EQ(IDR_ANDROID_INFOBAR_PREVIEWS, infobar->GetIconId());
+#else
+ ASSERT_EQ(PreviewsInfoBarDelegate::kNoIconID, infobar->GetIconId());
+#endif
+}
+
+TEST_F(PreviewsInfoBarDelegateUnitTest, OfflineInfobarTest) {
+ base::HistogramTester tester;
+
+ ConfirmInfoBarDelegate* infobar =
+ CreateInfoBar(PreviewsInfoBarDelegate::OFFLINE);
+
+ tester.ExpectUniqueSample(kUMAPreviewsInfoBarActionOffline,
+ PreviewsInfoBarDelegate::INFOBAR_SHOWN, 1);
+ EXPECT_EQ(0, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiUIShownPerSession));
+
+ // Check the strings.
+ ASSERT_TRUE(infobar);
+ ASSERT_EQ(l10n_util::GetStringUTF16(IDS_PREVIEWS_INFOBAR_FASTER_PAGE_TITLE),
+ infobar->GetMessageText());
+ ASSERT_EQ(l10n_util::GetStringUTF16(IDS_PREVIEWS_INFOBAR_LINK),
+ infobar->GetLinkText());
+#if defined(OS_ANDROID)
+ ASSERT_EQ(IDR_ANDROID_INFOBAR_PREVIEWS, infobar->GetIconId());
+#else
+ ASSERT_EQ(PreviewsInfoBarDelegate::kNoIconID, infobar->GetIconId());
+#endif
+}
« no previous file with comments | « chrome/browser/previews/previews_infobar_delegate.cc ('k') | chrome/browser/previews/previews_infobar_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698