Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6256)

Unified Diff: chrome/browser/previews/previews_infobar_tab_helper_unittest.cc

Issue 2266653002: Previews infobar tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddUMA
Patch Set: clamy comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
diff --git a/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc b/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dd462edd06c82b597bf142d7674b732079d460cb
--- /dev/null
+++ b/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
@@ -0,0 +1,104 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/previews/previews_infobar_tab_helper.h"
+
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
+#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
+#include "chrome/browser/previews/previews_infobar_tab_helper.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h"
+#include "components/prefs/pref_registry_simple.h"
+#include "components/proxy_config/proxy_config_pref_names.h"
+#include "content/public/browser/navigation_handle.h"
+#include "content/public/test/web_contents_tester.h"
+#include "net/http/http_response_headers.h"
+
+namespace {
+
bengr 2016/09/09 19:40:52 nit: can remove blank lines above and below.
megjablon 2016/09/09 20:38:41 Done.
+const char kTestUrl[] = "http://www.test.com/";
+
+}
+
+class PreviewsInfoBarTabHelperUnitTest
+ : public ChromeRenderViewHostTestHarness {
+ protected:
+ void SetUp() override {
+ ChromeRenderViewHostTestHarness::SetUp();
+ InfoBarService::CreateForWebContents(web_contents());
+ PreviewsInfoBarTabHelper::CreateForWebContents(web_contents());
+ test_handle_ = content::NavigationHandle::CreateNavigationHandleForTesting(
+ GURL(kTestUrl), main_rfh());
+
+ drp_test_context_ =
+ data_reduction_proxy::DataReductionProxyTestContext::Builder()
+ .WithMockConfig()
+ .SkipSettingsInitialization()
+ .Build();
+
+ auto* data_reduction_proxy_settings =
+ DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
+ web_contents()->GetBrowserContext());
+
+ PrefRegistrySimple* registry =
+ drp_test_context_->pref_service()->registry();
+ registry->RegisterDictionaryPref(proxy_config::prefs::kProxy);
+ data_reduction_proxy_settings
+ ->set_data_reduction_proxy_enabled_pref_name_for_test(
+ drp_test_context_->GetDataReductionProxyEnabledPrefName());
+ data_reduction_proxy_settings->InitDataReductionProxySettings(
+ drp_test_context_->io_data(), drp_test_context_->pref_service(),
+ drp_test_context_->request_context_getter(),
+ base::WrapUnique(new data_reduction_proxy::DataStore()),
+ base::ThreadTaskRunnerHandle::Get(),
+ base::ThreadTaskRunnerHandle::Get());
+ }
+
+ void TearDown() override {
+ drp_test_context_->DestroySettings();
+ ChromeRenderViewHostTestHarness::TearDown();
+ }
+
+ void SimulateWillProcessResponse() {
+ scoped_refptr<net::HttpResponseHeaders> headers =
+ new net::HttpResponseHeaders("");
+ headers->AddHeader(
+ std::string(data_reduction_proxy::chrome_proxy_header()) + ": " +
bengr 2016/09/09 19:40:52 I'd use StringPrintF in base to construct the stri
megjablon 2016/09/09 20:38:41 Done.
+ data_reduction_proxy::chrome_proxy_lo_fi_preview_directive());
+ test_handle_->CallWillProcessResponseForTesting(main_rfh(), headers);
+ test_handle_->CallDidCommitNavigationForTesting(GURL(kTestUrl));
+ }
+
+ void CallDidFinishNavigation() {
+ test_handle_.reset();
+ }
+
+ private:
+ std::unique_ptr<content::NavigationHandle> test_handle_;
+ std::unique_ptr<data_reduction_proxy::DataReductionProxyTestContext>
+ drp_test_context_;
+};
+
+TEST_F(PreviewsInfoBarTabHelperUnitTest, CreateLitePageInfoBar) {
+ PreviewsInfoBarTabHelper* infobar_tab_helper =
+ PreviewsInfoBarTabHelper::FromWebContents(web_contents());
+ EXPECT_FALSE(infobar_tab_helper->displayed_preview_infobar());
+
+ SimulateWillProcessResponse();
+ CallDidFinishNavigation();
+
+ InfoBarService* infobar_service =
+ InfoBarService::FromWebContents(web_contents());
+ EXPECT_EQ(1U, infobar_service->infobar_count());
+ EXPECT_TRUE(infobar_tab_helper->displayed_preview_infobar());
+
+ // Navigate to reset the displayed state.
+ content::WebContentsTester::For(web_contents())->
+ NavigateAndCommit(GURL(kTestUrl));
+ EXPECT_FALSE(infobar_tab_helper->displayed_preview_infobar());
+}

Powered by Google App Engine
This is Rietveld 408576698