components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc - Issue 2266653002: Previews infobar tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc

Issue 2266653002: Previews infobar tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddUMA

Patch Set: clamy comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/previews/previews_infobar_tab_helper_unittest.cc ('K') | « components/subresource_filter/content/browser/DEPS ('k') | content/browser/frame_host/navigation_handle_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc

diff --git a/components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc b/components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc

index c51cbf9aa08d5cc2054c1603273238bfd730f140..e2396df53f214a870462132dcc9cd5c752882699 100644

--- a/components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc

+++ b/components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc

@@ -8,6 +8,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

+#include "base/memory/ref_counted.h"

#include "base/metrics/field_trial.h"

#include "components/safe_browsing_db/util.h"

#include "components/subresource_filter/content/browser/content_subresource_filter_driver.h"

@@ -18,6 +19,7 @@

#include "content/public/browser/navigation_handle.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/test_renderer_host.h"

+#include "net/http/http_response_headers.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -113,7 +115,8 @@ class SubresourceFilterNavigationThrottleTest

}

void SimulateWillProcessResponse() {

- handle()->CallWillProcessResponseForTesting(main_rfh());

+ handle()->CallWillProcessResponseForTesting(

+ main_rfh(), scoped_refptr<net::HttpResponseHeaders>());

bengr 2016/09/09 19:40:52 Is there any way to do this without taking on a ne

megjablon 2016/09/09 20:38:41 Passing in strings and then creating the headers i

}

private: