Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 22647002: Add support to QUIC for QUIC_VERSION_8: for RSA-PSS signatures, set (Closed)

Created:
7 years, 4 months ago by wtc
Modified:
7 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add support to QUIC for QUIC_VERSION_8: for RSA-PSS signatures, set the salt length to the digest length. This is recommended by RFC 4055, Section 3.1: saltLength The saltLength field is the octet length of the salt. For a given hashAlgorithm, the recommended value of saltLength is the number of octets in the hash value. ... OpenSSL's default salt length is the special value -2. When signing, -2 sets the salt length to the maximum permissible value. When verifying, -2 causes the salt length to be automatically determined based on the PSS block structure. Merge internal CL: 50532662 R=rch@chromium.org,rtenneti@chromium.org BUG=none TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216608

Patch Set 1 #

Patch Set 2 : Remove the AES GCM files from the CL. Do not add QuicVersionMin(). #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -130 lines) Patch
M net/quic/crypto/crypto_server_config.h View 3 chunks +4 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/proof_source.h View 3 chunks +6 lines, -1 line 0 comments Download
M net/quic/crypto/proof_source_chromium.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/proof_source_chromium.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/proof_test.cc View 11 chunks +118 lines, -93 lines 0 comments Download
M net/quic/crypto/proof_verifier.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 4 chunks +6 lines, -4 lines 1 comment Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 3 chunks +12 lines, -6 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
rch: please review. ramant: just FYI. I am porting this CL of mine myself. https://codereview.chromium.org/22647002/diff/20001/net/quic/crypto/proof_verifier_chromium.cc ...
7 years, 4 months ago (2013-08-08 00:37:33 UTC) #1
Ryan Hamilton
lgtm
7 years, 4 months ago (2013-08-08 03:52:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/22647002/20001
7 years, 4 months ago (2013-08-08 17:30:01 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 06:38:38 UTC) #4
Message was sent while issue was closed.
Change committed as 216608

Powered by Google App Engine
This is Rietveld 408576698