Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22642002: 'extends Element' (Closed)

Created:
7 years, 4 months ago by sra1
Modified:
7 years, 4 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Additional code to https://codereview.chromium.org/15026006 to enable user classes extending DOM classes to be registered. Committed: https://code.google.com/p/dart/source/detail?r=26221

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -19 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/interceptors.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +77 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +42 lines, -3 lines 0 comments Download
M tests/html/custom_elements_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
A tools/dom/src/dart2js_CustomElementSupport.dart View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
Hi Pete, This CL is really just dart:html extensions to https://codereview.chromium.org/15026006 So just review the ...
7 years, 4 months ago (2013-08-09 03:00:53 UTC) #1
blois
https://codereview.chromium.org/22642002/diff/3001/tools/dom/src/dart2js_CustomElementSupport.dart File tools/dom/src/dart2js_CustomElementSupport.dart (right): https://codereview.chromium.org/22642002/diff/3001/tools/dom/src/dart2js_CustomElementSupport.dart#newcode5 tools/dom/src/dart2js_CustomElementSupport.dart:5: part of html; should be dart.dom.html https://codereview.chromium.org/22642002/diff/3001/tools/dom/src/dart2js_CustomElementSupport.dart#newcode24 tools/dom/src/dart2js_CustomElementSupport.dart:24: callOnCreated(receiver) ...
7 years, 4 months ago (2013-08-09 16:06:23 UTC) #2
sra1
PTAL https://chromiumcodereview.appspot.com/22642002/diff/3001/tools/dom/src/dart2js_CustomElementSupport.dart File tools/dom/src/dart2js_CustomElementSupport.dart (right): https://chromiumcodereview.appspot.com/22642002/diff/3001/tools/dom/src/dart2js_CustomElementSupport.dart#newcode5 tools/dom/src/dart2js_CustomElementSupport.dart:5: part of html; On 2013/08/09 16:06:23, blois wrote: ...
7 years, 4 months ago (2013-08-12 23:31:26 UTC) #3
sra1
7 years, 4 months ago (2013-08-15 21:18:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r26221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698