Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2263433002: Remove Lo-Fi snackbar code (Closed)

Created:
4 years, 4 months ago by megjablon
Modified:
4 years, 3 months ago
Reviewers:
bengr, Charlie Reis, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddTabHelper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Lo-Fi snackbar code The Lo-Fi snackbar has been replaced by the previews infobar. Remove the snackbar and all associated code. BUG=615566 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/0dc7ce1eee1f2169057a2cac576f479b473afcaf Cr-Commit-Position: refs/heads/master@{#418595}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : remove strings #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -304 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java View 2 chunks +0 lines, -20 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 3 7 chunks +0 lines, -39 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (21 generated)
megjablon
bengr: chrome/browser/net/* dfalcantara: chrome/android/* and chrome/browser/android/* creis: content/*
4 years, 3 months ago (2016-08-30 18:24:50 UTC) #9
Charlie Reis
content/ LGTM. Thanks for the cleanup!
4 years, 3 months ago (2016-08-31 16:45:59 UTC) #10
gone
lgtm
4 years, 3 months ago (2016-08-31 17:34:42 UTC) #11
bengr
lgtm. Thanks for cleaning up!
4 years, 3 months ago (2016-08-31 23:46:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263433002/120001
4 years, 3 months ago (2016-09-14 16:57:18 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 3 months ago (2016-09-14 17:03:07 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 17:04:53 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0dc7ce1eee1f2169057a2cac576f479b473afcaf
Cr-Commit-Position: refs/heads/master@{#418595}

Powered by Google App Engine
This is Rietveld 408576698