Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2263433002: Remove Lo-Fi snackbar code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddTabHelper
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index f97f467908e0ad2af404f8aed63c22a52cd2777b..cd2483c6a21fab6f8fc74a00b6e3fb54a8f00278 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -32,7 +32,6 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.ContextUtils;
import org.chromium.base.ObserverList;
import org.chromium.base.ObserverList.RewindableIterator;
-import org.chromium.base.ThreadUtils;
import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
@@ -74,7 +73,6 @@ import org.chromium.chrome.browser.printing.TabPrinter;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.rlz.RevenueStats;
import org.chromium.chrome.browser.search_engines.TemplateUrlService;
-import org.chromium.chrome.browser.snackbar.LofiBarController;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.ssl.SecurityStateModel;
import org.chromium.chrome.browser.tab.TabUma.TabCreationState;
@@ -382,8 +380,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
protected Handler mHandler;
- private LofiBarController mLoFiBarController;
-
/** Whether or not the tab closing the tab can send the user back to the app that opened it. */
private boolean mIsAllowedToReturnToExternalApp;
@@ -1032,16 +1028,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
/**
- * Reloads the current page content with Lo-Fi off.
- * This version ignores the cache and reloads from the network.
- */
- public void reloadDisableLoFi() {
- if (getWebContents() != null) {
- getWebContents().getNavigationController().reloadDisableLoFi(true);
- }
- }
-
- /**
* Reloads all the Lo-Fi images in this Tab's WebContents.
* This version ignores the cache and reloads from the network.
*/
@@ -1768,10 +1754,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
protected void didStartPageLoad(String validatedUrl, boolean showingErrorPage) {
mIsFullscreenWaitingForLoad = !DomDistillerUrlUtils.isDistilledPage(validatedUrl);
- if (getLoFiBarController() != null) {
- mLoFiBarController.resetLoFiPopupShownForPageLoad();
- }
-
updateTitle();
removeSadTabIfPresent();
@@ -2520,15 +2502,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
return getActivity().getSnackbarManager();
}
- private LofiBarController getLoFiBarController() {
- ThreadUtils.assertOnUiThread();
- if (mLoFiBarController == null && getSnackbarManager() != null) {
- mLoFiBarController =
- new LofiBarController(mThemedApplicationContext, getSnackbarManager());
- }
- return mLoFiBarController;
- }
-
/**
* @return The native pointer representing the native side of this {@link Tab} object.
*/
@@ -2974,18 +2947,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
/**
- * If a Lo-Fi snackbar has not been shown yet for this page load, a Lo-Fi snackbar is shown.
- *
- * @param isPreview Whether the Lo-Fi response was a preview response.
- */
- @CalledByNative
- public void onLoFiResponseReceived(boolean isPreview) {
- if (getLoFiBarController() != null) {
- mLoFiBarController.maybeCreateLoFiBar(this, isPreview);
- }
- }
-
- /**
* Request that this tab receive focus. Currently, this function requests focus for the main
* View (usually a ContentView).
*/

Powered by Google App Engine
This is Rietveld 408576698