Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index f589a9ce9d80fed1b40fe07788c71afc35b174c5..4837e56270e3bb2709eb7cf3cf6a473c98e20619 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -5006,15 +5006,13 @@ class AsyncLoggingUrlRequestDelegate : public TestDelegate {
base::Unretained(this), request, redirect_info));
}
- void OnResponseStarted(URLRequest* request) override {
+ void OnResponseStarted(URLRequest* request, int net_error) override {
AsyncDelegateLogger::Run(
- request,
- LOAD_STATE_WAITING_FOR_DELEGATE,
- LOAD_STATE_WAITING_FOR_DELEGATE,
- LOAD_STATE_WAITING_FOR_DELEGATE,
- base::Bind(
- &AsyncLoggingUrlRequestDelegate::OnResponseStartedLoggingComplete,
- base::Unretained(this), request));
+ request, LOAD_STATE_WAITING_FOR_DELEGATE,
+ LOAD_STATE_WAITING_FOR_DELEGATE, LOAD_STATE_WAITING_FOR_DELEGATE,
+ base::Bind(
+ &AsyncLoggingUrlRequestDelegate::OnResponseStartedLoggingComplete,
+ base::Unretained(this), request, net_error));
}
void OnReadCompleted(URLRequest* request, int bytes_read) override {
@@ -5040,9 +5038,9 @@ class AsyncLoggingUrlRequestDelegate : public TestDelegate {
request->FollowDeferredRedirect();
}
- void OnResponseStartedLoggingComplete(URLRequest* request) {
+ void OnResponseStartedLoggingComplete(URLRequest* request, int net_error) {
// The parent class continues the request.
- TestDelegate::OnResponseStarted(request);
+ TestDelegate::OnResponseStarted(request, net_error);
}
void AfterReadCompletedLoggingComplete(URLRequest* request, int bytes_read) {
« net/base/layered_network_delegate.h ('K') | « net/url_request/url_request_test_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698