Fix background blending for some cases where it did not work at all. The fix adds the blendMode par…

Source/core/platform/graphics/ImageBuffer.h

Index: Source/core/platform/graphics/ImageBuffer.h
diff --git a/Source/core/platform/graphics/ImageBuffer.h b/Source/core/platform/graphics/ImageBuffer.h
index 935c911531a71ff6f44804cf27eaf05398ca2a04..b4c0af9f3398dd1bf1c444c0504560a68ecf1f4a 100644
--- a/Source/core/platform/graphics/ImageBuffer.h
+++ b/Source/core/platform/graphics/ImageBuffer.h
@@ -134,7 +134,7 @@ private:
     bool isValid() const;
 
     void draw(GraphicsContext*, const FloatRect&, const FloatRect& = FloatRect(0, 0, -1, -1), CompositeOperator = CompositeSourceOver, BlendMode = BlendModeNormal, bool useLowQualityScale = false);
-    void drawPattern(GraphicsContext*, const FloatRect&, const FloatSize&, const FloatPoint&, CompositeOperator, const FloatRect&);
+    void drawPattern(GraphicsContext*, const FloatRect&, const FloatSize&, const FloatPoint&, CompositeOperator, const FloatRect&, BlendMode);

[Horia Olaru, 2013/08/07 21:31:44]

I would like to move the BlendMode parameter in a future patch, to be next to
the composite operator, because I think that is where it belongs. Would that be
acceptable?

Also, I am thinking of removing the default "BlendModeNormal" in the future.
There have been quite a few bugs because various draw* functions did not having
the BlendMode parameter passed in because of it. How does that sound? I haven't
played with this yet, so I am not sure if there are cases where someone would
actually use the default.

Where should I discuss such issues, before starting to work on them?

 
     friend class GraphicsContext;
     friend class GeneratedImage;