Fix background blending for some cases where it did not work at all. The fix adds the blendMode par…

Source/core/platform/graphics/ImageBuffer.h

 /*
  * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 116 matching lines @@
 
     // FIXME: current implementations of this method have the restriction that they only work
     // with textures that are RGB or RGBA format, UNSIGNED_BYTE type and level 0, as specified in
     // Extensions3D::canUseCopyTextureCHROMIUM().
     bool copyToPlatformTexture(GraphicsContext3D&, Platform3DObject, GC3Denum, GC3Denum, GC3Dint, bool, bool);
 
 private:
     bool isValid() const;
 
     void draw(GraphicsContext*, const FloatRect&, const FloatRect& = FloatRect(0, 0, -1, -1), CompositeOperator = CompositeSourceOver, BlendMode = BlendModeNormal, bool useLowQualityScale = false);
-    void drawPattern(GraphicsContext*, const FloatRect&, const FloatSize&, const FloatPoint&, CompositeOperator, const FloatRect&);
+    void drawPattern(GraphicsContext*, const FloatRect&, const FloatSize&, const FloatPoint&, CompositeOperator, const FloatRect&, BlendMode);

[Horia Olaru, 2013/08/07 21:31:44]

I would like to move the BlendMode parameter in a future patch, to be next to
the composite operator, because I think that is where it belongs. Would that be
acceptable?

Also, I am thinking of removing the default "BlendModeNormal" in the future.
There have been quite a few bugs because various draw* functions did not having
the BlendMode parameter passed in because of it. How does that sound? I haven't
played with this yet, so I am not sure if there are cases where someone would
actually use the default.

Where should I discuss such issues, before starting to work on them?

 
     friend class GraphicsContext;
     friend class GeneratedImage;
     friend class CrossfadeGeneratedImage;
     friend class GeneratorGeneratedImage;
 
     IntSize m_size;
     IntSize m_logicalSize;
     float m_resolutionScale;
     OwnPtr<SkCanvas> m_canvas;
     OwnPtr<GraphicsContext> m_context;
     OwnPtr<Canvas2DLayerBridge> m_layerBridge;
 
     // This constructor will place its success into the given out-variable
     // so that create() knows when it should return failure.
     ImageBuffer(const IntSize&, float resolutionScale, RenderingMode, OpacityMode, bool& success);
     ImageBuffer(const IntSize&, float resolutionScale, const GraphicsContext*, bool hasAlpha, bool& success);
 };
 
 String ImageDataToDataURL(const ImageData&, const String& mimeType, const double* quality);
 
 } // namespace WebCore
 
 #endif // ImageBuffer_h