Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2258873004: Leak Detector: Count ScriptPromise and ActiveDOMObject on worker threads (Closed)

Created:
4 years, 4 months ago by hajimehoshi
Modified:
4 years, 4 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Leak Detector: Count ScriptPromise and ActiveDOMObject on worker threads This CL makes the leak detector count ScriptPromise and ActiveDOMObject not only on the main thread but also on worker threads. There was a bug that the worker threads don't wait for the termination (crbug.com/507224) and we couldn't count those objects on worker threads correctly, but now the bug has been fixed. BUG=506466, 506799, 507574 Committed: https://crrev.com/f3d1a58111d4763fb364d39498e2053cada1c50d Cr-Commit-Position: refs/heads/master@{#413474}

Patch Set 1 #

Patch Set 2 : Bug fix: Build fail on ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InstanceCounters.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InstanceCounters.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (16 generated)
hajimehoshi
PTAL
4 years, 4 months ago (2016-08-19 08:23:17 UTC) #4
hajimehoshi
I tested the leak detector of 'fast' tests and confirmed no ScriptPromise or ActiveDOMObject leaks.: ...
4 years, 4 months ago (2016-08-19 08:33:16 UTC) #7
haraken
LGTM
4 years, 4 months ago (2016-08-19 09:19:23 UTC) #10
kouhei (in TOK)
lgtm
4 years, 4 months ago (2016-08-21 23:42:36 UTC) #11
hajimehoshi
Confirmed there are no new leaks in all layout tests. yurys: PTAL at core/inspector
4 years, 4 months ago (2016-08-22 09:22:21 UTC) #16
kozy
@yurys transferred to another team. lgtm.
4 years, 4 months ago (2016-08-22 17:42:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258873004/20001
4 years, 4 months ago (2016-08-22 17:56:15 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 18:04:22 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:06:22 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3d1a58111d4763fb364d39498e2053cada1c50d
Cr-Commit-Position: refs/heads/master@{#413474}

Powered by Google App Engine
This is Rietveld 408576698