Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

Issue 2258873004: Leak Detector: Count ScriptPromise and ActiveDOMObject on worker threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bug fix: Build fail on ChromeOS Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 return promise; 309 return promise;
310 } 310 }
311 311
312 ScriptPromise ScriptPromise::all(ScriptState* scriptState, const Vector<ScriptPr omise>& promises) 312 ScriptPromise ScriptPromise::all(ScriptState* scriptState, const Vector<ScriptPr omise>& promises)
313 { 313 {
314 return PromiseAllHandler::all(scriptState, promises); 314 return PromiseAllHandler::all(scriptState, promises);
315 } 315 }
316 316
317 void ScriptPromise::increaseInstanceCount() 317 void ScriptPromise::increaseInstanceCount()
318 { 318 {
319 // An instance is only counted only on the main thread. This is because the 319 InstanceCounters::incrementCounter(InstanceCounters::ScriptPromiseCounter);
320 // leak detector can detect leaks on the main thread so far. We plan to fix
321 // the leak detector to work on worker threads (crbug.com/507224).
322 if (isMainThread())
323 InstanceCounters::incrementCounter(InstanceCounters::ScriptPromiseCounte r);
324 } 320 }
325 321
326 void ScriptPromise::decreaseInstanceCount() 322 void ScriptPromise::decreaseInstanceCount()
327 { 323 {
328 if (isMainThread()) 324 InstanceCounters::decrementCounter(InstanceCounters::ScriptPromiseCounter);
329 InstanceCounters::decrementCounter(InstanceCounters::ScriptPromiseCounte r);
330 } 325 }
331 326
332 } // namespace blink 327 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698