Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3528)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java

Issue 2258283002: UMA for previews infobar and Lo-Fi context menu items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarRemoveAndroid
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java
index 778e444cc9304f5cd4e4e5397cd3d31717dbc8f2..8d261580a66306171348f5634b4314509d0a4431 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java
@@ -27,17 +27,14 @@ public class DataReductionProxyUma {
public static final int ACTION_INFOBAR_DISMISSED = 12;
public static final int ACTION_INDEX_BOUNDARY = 13;
- // Represent the possible Lo-Fi user actions. This must remain in sync with
- // DataReductionProxy.UIAction.LoFi in tools/metrics/histograms/histograms.xml.
- public static final int ACTION_LOAD_IMAGES_SNACKBAR_SHOWN = 0;
- public static final int ACTION_LOAD_IMAGES_SNACKBAR_CLICKED = 1;
- public static final int ACTION_LOAD_IMAGE_CONTEXT_MENU_SHOWN = 2;
- public static final int ACTION_LOAD_IMAGE_CONTEXT_MENU_CLICKED = 3;
- public static final int ACTION_LOAD_IMAGE_CONTEXT_MENU_CLICKED_ON_PAGE = 4;
- public static final int ACTION_LOAD_IMAGES_CONTEXT_MENU_SHOWN = 5;
- public static final int ACTION_LOAD_IMAGES_CONTEXT_MENU_CLICKED = 6;
- public static final int LOFI_ACTION_INDEX_BOUNDARY = 7;
-
+ // Represent the possible Lo-Fi context menu user actions. This must remain in sync with
+ // Previews.ContextMenuAction.LoFi in tools/metrics/histograms/histograms.xml.
+ public static final int ACTION_LOFI_LOAD_IMAGE_CONTEXT_MENU_SHOWN = 0;
+ public static final int ACTION_LOFI_LOAD_IMAGE_CONTEXT_MENU_CLICKED = 1;
+ public static final int ACTION_LOFI_LOAD_IMAGE_CONTEXT_MENU_CLICKED_ON_PAGE = 2;
+ public static final int ACTION_LOFI_LOAD_IMAGES_CONTEXT_MENU_SHOWN = 3;
+ public static final int ACTION_LOFI_LOAD_IMAGES_CONTEXT_MENU_CLICKED = 4;
+ public static final int ACTION_LOFI_CONTEXT_MENU_INDEX_BOUNDARY = 5;
/**
* Record the DataReductionProxy.UIAction histogram.
* @param action User action at the promo, first run experience, or settings screen
@@ -50,13 +47,13 @@ public class DataReductionProxyUma {
}
/**
- * Record the DataReductionProxy.UIAction.LoFi histogram.
- * @param action LoFi user action on the snackbar or context menu
+ * Record the Previews.ContextMenuAction.LoFi histogram.
+ * @param action LoFi user action on the context menu
*/
- public static void dataReductionProxyLoFiUIAction(int action) {
- assert action >= 0 && action < LOFI_ACTION_INDEX_BOUNDARY;
+ public static void previewsLoFiContextMenuAction(int action) {
+ assert action >= 0 && action < ACTION_LOFI_CONTEXT_MENU_INDEX_BOUNDARY;
RecordHistogram.recordEnumeratedHistogram(
- "DataReductionProxy.LoFi.UIAction", action,
- DataReductionProxyUma.LOFI_ACTION_INDEX_BOUNDARY);
+ "Previews.ContextMenuAction.LoFi", action,
+ ACTION_LOFI_CONTEXT_MENU_INDEX_BOUNDARY);
}
}

Powered by Google App Engine
This is Rietveld 408576698