Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2804)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2258283002: UMA for previews infobar and Lo-Fi context menu items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarRemoveAndroid
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
index 6ea3a7f29204145022347a0d5125906038f77860..34ac23da780f10a855e066d7a9a8da506113f770 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
@@ -241,16 +241,16 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
// properties can also prevent an image underlying a link from being clickable.
// When Lo-Fi is active, provide the user with a "Load images" option on links
// to get the images in these cases.
- DataReductionProxyUma.dataReductionProxyLoFiUIAction(
- DataReductionProxyUma.ACTION_LOAD_IMAGES_CONTEXT_MENU_SHOWN);
+ DataReductionProxyUma.previewsLoFiContextMenuAction(
+ DataReductionProxyUma.ACTION_LOFI_LOAD_IMAGES_CONTEXT_MENU_SHOWN);
}
if (params.isVideo()) {
menu.findItem(R.id.contextmenu_save_video).setVisible(
params.canSaveMedia() && UrlUtilities.isDownloadableScheme(params.getSrcUrl()));
} else if (params.isImage() && params.imageWasFetchedLoFi()) {
- DataReductionProxyUma.dataReductionProxyLoFiUIAction(
- DataReductionProxyUma.ACTION_LOAD_IMAGE_CONTEXT_MENU_SHOWN);
+ DataReductionProxyUma.previewsLoFiContextMenuAction(
+ DataReductionProxyUma.ACTION_LOFI_LOAD_IMAGE_CONTEXT_MENU_SHOWN);
// All image context menu items other than "Load image," "Open original image in
// new tab," and "Copy image URL" should be disabled on Lo-Fi images.
menu.findItem(R.id.contextmenu_save_image).setVisible(false);
@@ -325,16 +325,16 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
mDelegate.onOpenImageInNewTab(params.getSrcUrl(), params.getReferrer());
} else if (itemId == R.id.contextmenu_load_images) {
ContextMenuUma.record(params, ContextMenuUma.ACTION_LOAD_IMAGES);
- DataReductionProxyUma.dataReductionProxyLoFiUIAction(
- DataReductionProxyUma.ACTION_LOAD_IMAGES_CONTEXT_MENU_CLICKED);
+ DataReductionProxyUma.previewsLoFiContextMenuAction(
+ DataReductionProxyUma.ACTION_LOFI_LOAD_IMAGES_CONTEXT_MENU_CLICKED);
mDelegate.onReloadLoFiImages();
} else if (itemId == R.id.contextmenu_load_original_image) {
ContextMenuUma.record(params, ContextMenuUma.ACTION_LOAD_ORIGINAL_IMAGE);
- DataReductionProxyUma.dataReductionProxyLoFiUIAction(
- DataReductionProxyUma.ACTION_LOAD_IMAGE_CONTEXT_MENU_CLICKED);
+ DataReductionProxyUma.previewsLoFiContextMenuAction(
+ DataReductionProxyUma.ACTION_LOFI_LOAD_IMAGE_CONTEXT_MENU_CLICKED);
if (!DataReductionProxySettings.getInstance().wasLoFiLoadImageRequestedBefore()) {
- DataReductionProxyUma.dataReductionProxyLoFiUIAction(
- DataReductionProxyUma.ACTION_LOAD_IMAGE_CONTEXT_MENU_CLICKED_ON_PAGE);
+ DataReductionProxyUma.previewsLoFiContextMenuAction(
+ DataReductionProxyUma.ACTION_LOFI_LOAD_IMAGE_CONTEXT_MENU_CLICKED_ON_PAGE);
DataReductionProxySettings.getInstance().setLoFiLoadImageRequested();
}
mDelegate.onLoadOriginalImage();
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698