Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22572005: Remove all uses of the ASCIILiteral class. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kenneth.christiansen, kojih, loislo+blink_chromium.org, jsbell+bindings_chromium.org, aboxhall, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Nate Chapin, jeez, do-not-use
Visibility:
Public.

Description

Remove all uses of the ASCIILiteral class. This class doesn't do anything anymore. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155917

Patch Set 1 #

Patch Set 2 : dom #

Patch Set 3 : editing #

Patch Set 4 : html #

Patch Set 5 : loader #

Patch Set 6 : page #

Patch Set 7 : platform #

Patch Set 8 : rendering, svg, xml #

Patch Set 9 : modules crypto #

Patch Set 10 : modules geolocation #

Patch Set 11 : modules mediastream #

Patch Set 12 : modules rest #

Patch Set 13 : fix two cases in wtf #

Patch Set 14 : rm it from wtf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -332 lines) Patch
M Source/bindings/v8/ScriptEventListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8BlobCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityMediaControls.cpp View 5 chunks +21 lines, -21 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMException.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/SmartReplaceICU.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/BaseCheckableInputType.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/BaseChooserOnlyDateAndTimeInputType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormController.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/ImageInputType.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElements.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 2 3 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.cpp View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/cache/ScriptResource.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ContentSecurityPolicy.cpp View 1 2 3 4 5 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/page/DiagnosticLoggingKeys.cpp View 1 2 3 4 5 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageVisibilityState.cpp View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/page/UserContentURLPattern.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/animation/CSSAnimationData.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/ClipboardUtilitiesChromium.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/GraphicsContextAnnotation.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/GraphicsContextAnnotation.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/network/HTTPParsers.cpp View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/platform/sql/SQLiteDatabase.cpp View 1 2 3 4 5 6 11 chunks +13 lines, -13 lines 0 comments Download
M Source/core/platform/text/DateTimeFormat.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/LocaleICU.cpp View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/text/TextBreakIteratorICU.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBR.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProvider.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAngle.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTransform.cpp View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Algorithm.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Key.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/Geolocation.cpp View 1 2 3 4 5 6 7 8 9 8 chunks +11 lines, -10 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/mediastream/SourceInfo.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionError.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +9 lines, -9 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketPerMessageDeflate.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/weborigin/SecurityOrigin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/tests/StringOperators.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/tests/WTFString.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/text/AtomicString.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -3 lines 0 comments Download
M Source/wtf/text/StringConcatenate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -28 lines 0 comments Download
M Source/wtf/text/StringOperators.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -16 lines 0 comments Download
M Source/wtf/text/WTFString.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
big, trivial, nothing exciting to review. ptal, thanks
7 years, 4 months ago (2013-08-11 23:23:43 UTC) #1
abarth-chromium
LGTM. Thanks!
7 years, 4 months ago (2013-08-11 23:32:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/22572005/27001
7 years, 4 months ago (2013-08-12 00:05:27 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 01:26:45 UTC) #4
Message was sent while issue was closed. 
Change committed as 155917

Powered by Google App Engine
This is Rietveld 408576698