Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 22562004: Fix Object.freeze, Object.observe wrt CountOperation and CompoundAssignment. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix Object.freeze, Object.observe wrt CountOperation and CompoundAssignment. BUG=2774, 2779 R=adamk@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16111

Patch Set 1 #

Patch Set 2 : Reenable Object.observe test #

Patch Set 3 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-freeze.js View 1 2 1 chunk +16 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-08-07 18:30:29 UTC) #1
adamk
lgtm Thanks for picking this up!
7 years, 4 months ago (2013-08-07 18:44:36 UTC) #2
Toon Verwaest
7 years, 4 months ago (2013-08-07 18:45:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698