src/typing.cc - Issue 22562004: Fix Object.freeze, Object.observe wrt CountOperation and CompoundAssignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 22562004: Fix Object.freeze, Object.observe wrt CountOperation and CompoundAssignment. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add regression test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index df2cee51e9e7553404a10004922c53de4ee89294..f8e2a7c206d80ee0e4b26096f97cb4173c88132f 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -388,9 +388,7 @@ void AstTyper::VisitAssignment(Assignment* expr) {

Property* prop = target->AsProperty();

if (prop != NULL) {

prop->RecordTypeFeedback(oracle(), zone());

- if (!prop->key()->IsPropertyName()) { // i.e., keyed

- expr->RecordTypeFeedback(oracle(), zone());

- }

+ expr->RecordTypeFeedback(oracle(), zone());

}

RECURSE(Visit(expr->binary_operation()));

« no previous file with comments | « src/hydrogen.cc ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »