Issue 22555004: Make all load-named-fields depend on their map-check, unless explicitly ignored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22555004: Make all load-named-fields depend on their map-check, unless explicitly ignored. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Make all load-named-fields depend on their map-check, unless explicitly ignored. BUG= R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16139

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -50 lines)			Patch
M	src/code-stubs-hydrogen.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View		13 chunks	+21 lines, -19 lines	0 comments	Download
M	src/hydrogen-gvn.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-hoist-load-named-field.js	View		1 chunk	+28 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

titzer

LGTM, this kind of missing dependency bug is probably more common than we want to ...

7 years, 4 months ago (2013-08-09 18:39:28 UTC) #2

Toon Verwaest

7 years, 4 months ago (2013-08-09 18:40:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16139 (presubmit successful).