src/hydrogen-gvn.h - Issue 22555004: Make all load-named-fields depend on their map-check, unless explicitly ignored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-gvn.h

Issue 22555004: Make all load-named-fields depend on their map-check, unless explicitly ignored. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Replace ASSERT by TODO Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-gvn.h

diff --git a/src/hydrogen-gvn.h b/src/hydrogen-gvn.h

index 64a0fec76bf7db030ac9f09c34bb3a4af7bfbd27..fdbad99c6bb4de6d2250dd427ef05ef5b6877ead 100644

--- a/src/hydrogen-gvn.h

+++ b/src/hydrogen-gvn.h

@@ -48,7 +48,7 @@ class HGlobalValueNumberingPhase : public HPhase {

// instructions during the first pass.

if (FLAG_smi_only_arrays && removed_side_effects_) {

Analyze();

- ASSERT(!removed_side_effects_);

+ // TODO(danno): Turn this into a fixpoint iteration.

}

« no previous file with comments | « src/hydrogen.cc ('k') | test/mjsunit/regress/regress-hoist-load-named-field.js » ('j') | no next file with comments »