Issue 22548008: EventSender::contextClick leaks NPObject used as its return value, leading to a leak of DOMWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22548008: EventSender::contextClick leaks NPObject used as its return value, leading to a leak of DOMWindow. (Closed)

Created:
7 years, 4 months ago by kouhei (in TOK)

Modified:
7 years, 4 months ago

Reviewers:
haraken

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

EventSender::contextClick leaks NPObject used as its return value, leading to a leak of DOMWindow. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155772

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -0 lines)			Patch
A	LayoutTests/fast/events/event-sender-context-click-leak-document.html	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/events/event-sender-context-click-leak-document-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/testing/runner/EventSender.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

kouhei (in TOK)

haraken: r? There's likely more similar leaks from misusing WebBindings::make* methods. I'll post fixes for ...

7 years, 4 months ago (2013-08-08 09:09:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/22548008/1

7 years, 4 months ago (2013-08-08 09:49:37 UTC) #4

Message was sent while issue was closed.

Change committed as 155772