Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2422)

Unified Diff: Source/testing/runner/EventSender.cpp

Issue 22548008: EventSender::contextClick leaks NPObject used as its return value, leading to a leak of DOMWindow. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/event-sender-context-click-leak-document-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/testing/runner/EventSender.cpp
diff --git a/Source/testing/runner/EventSender.cpp b/Source/testing/runner/EventSender.cpp
index b56a6e10349d26bc1c54be26108cb8571b9efb1b..3fcecb0286e347bd053dd0f32ad794319e1abf9b 100644
--- a/Source/testing/runner/EventSender.cpp
+++ b/Source/testing/runner/EventSender.cpp
@@ -891,7 +891,11 @@ void EventSender::contextClick(const CppArgumentList& arguments, CppVariant* res
pressedButton = WebMouseEvent::ButtonNone;
#endif
- result->set(WebBindings::makeStringArray(makeMenuItemStringsFor(m_lastContextMenuData.get(), m_delegate)));
+ NPObject* resultArray = WebBindings::makeStringArray(makeMenuItemStringsFor(m_lastContextMenuData.get(), m_delegate));
+ result->set(resultArray);
+ WebBindings::releaseObject(resultArray);
+
+ m_lastContextMenuData.reset();
}
class MouseDownTask: public WebMethodTask<EventSender> {
« no previous file with comments | « LayoutTests/fast/events/event-sender-context-click-leak-document-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698