Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2254623003:
Submit button added to user pod. (Closed)
|
Created:
4 years, 4 months ago by sammiequon Modified:
4 years, 3 months ago CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSubmit button added to user pod.
This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20Pin%20lock%20pods.png%3Fz=width. Moves the caps lock button accordingly.
BUG=638643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/29276a7a0b4a0d59fa0a420cf9e7885286020bc4
Cr-Commit-Position: refs/heads/master@{#415804}
Patch Set 1 #
Total comments: 12
Patch Set 2 : Lazy load polymer. #
Total comments: 8
Patch Set 3 : Fixed patch set 2 errors. #
Total comments: 8
Patch Set 4 : Rebased. #
Total comments: 8
Patch Set 5 : Fixed patch set 4 errors. #
Total comments: 6
Patch Set 6 : Fixed patch set 6 errors. #
Total comments: 4
Patch Set 7 : Some VK compatibility issues. #
Total comments: 7
Patch Set 8 : Nit. #Patch Set 9 : Added chromeOS check. #Patch Set 10 : Rebased. #Messages
Total messages: 40 (14 generated)
Description was changed from ========== Submit button added to user pod. BUG=638643 ========== to ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 ==========
sammiequon@chromium.org changed reviewers: + jdufault@chromium.org
jdufault@ - Please take a look. Thanks!
https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... File ui/login/account_picker/user_pod_row.css (right): https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:228: color: blue; Is this the right color? https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:231: padding: 11.5px 10px; What is the 11.5px for? https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:232: position: absolute; Can we position relative to other elements instead of absolute? https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:237: color: red; Is this the right color? https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:307: position: absolute; Can this be positioned relative to other elements? https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... File ui/login/account_picker/user_pod_template.html (right): https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_template.html:2: <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-iconset-svg.html"> Lazy load these imports from javascript, similar to how the PIN keyboard is loaded.
Description was changed from ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 ========== to ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... File ui/login/account_picker/user_pod_row.css (right): https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:228: color: blue; On 2016/08/17 19:04:12, jdufault wrote: > Is this the right color? Done. https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:231: padding: 11.5px 10px; On 2016/08/17 19:04:12, jdufault wrote: > What is the 11.5px for? From the mocks. To place the icon i presume. https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:232: position: absolute; On 2016/08/17 19:04:12, jdufault wrote: > Can we position relative to other elements instead of absolute? Done. https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:237: color: red; On 2016/08/17 19:04:12, jdufault wrote: > Is this the right color? Done. https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_row.css:307: position: absolute; On 2016/08/17 19:04:12, jdufault wrote: > Can this be positioned relative to other elements? Done. https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... File ui/login/account_picker/user_pod_template.html (right): https://codereview.chromium.org/2254623003/diff/1/ui/login/account_picker/use... ui/login/account_picker/user_pod_template.html:2: <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-iconset-svg.html"> On 2016/08/17 19:04:12, jdufault wrote: > Lazy load these imports from javascript, similar to how the PIN keyboard is > loaded. Done.
https://codereview.chromium.org/2254623003/diff/60001/chrome/browser/resource... File chrome/browser/resources/chromeos/login/custom_elements_userpod.html (right): https://codereview.chromium.org/2254623003/diff/60001/chrome/browser/resource... chrome/browser/resources/chromeos/login/custom_elements_userpod.html:2: <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html"> Use custom_elements_lock.html? https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:777: { url: 'chrome://oobe/custom_elements_userpod.html'}] Cleanup formatting https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:2637: if (this.focusedPod_) Move this so it's defined next to setFocusedPodPinVisibility? https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... File ui/login/account_picker/user_pod_template.html (right): https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... ui/login/account_picker/user_pod_template.html:10: </svg> Fix indentation
Yesterdays patch with errors isn't on lkgr yet so I will fix those on a different cl. https://codereview.chromium.org/2254623003/diff/60001/chrome/browser/resource... File chrome/browser/resources/chromeos/login/custom_elements_userpod.html (right): https://codereview.chromium.org/2254623003/diff/60001/chrome/browser/resource... chrome/browser/resources/chromeos/login/custom_elements_userpod.html:2: <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html"> On 2016/08/30 17:34:18, jdufault wrote: > Use custom_elements_lock.html? Done. https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:777: { url: 'chrome://oobe/custom_elements_userpod.html'}] On 2016/08/30 17:34:18, jdufault wrote: > Cleanup formatting Done. https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:2637: if (this.focusedPod_) On 2016/08/30 17:34:18, jdufault wrote: > Move this so it's defined next to setFocusedPodPinVisibility? Done. https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... File ui/login/account_picker/user_pod_template.html (right): https://codereview.chromium.org/2254623003/diff/60001/ui/login/account_picker... ui/login/account_picker/user_pod_template.html:10: </svg> On 2016/08/30 17:34:18, jdufault wrote: > Fix indentation Done.
https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:770: // Lazy load the assets need for the polymer submit button. This is going to always load the PIN keyboard. This means we can eliminate / refactor the PIN keyboard loading code so it doesn't use ResourceLoader anymore. https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:771: if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('userpod-polymer')) 'custom-elements' https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:775: id: 'userpod-polymer', 'custom-elements' https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:779: function() {}); emit function
https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:770: // Lazy load the assets need for the polymer submit button. On 2016/08/30 18:21:58, jdufault wrote: > This is going to always load the PIN keyboard. This means we can eliminate / > refactor the PIN keyboard loading code so it doesn't use ResourceLoader anymore. As per our offline chat we will keep this seperate. https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:771: if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('userpod-polymer')) On 2016/08/30 18:21:58, jdufault wrote: > 'custom-elements' As per our offline chat we will keep this seperate. https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:775: id: 'userpod-polymer', On 2016/08/30 18:21:58, jdufault wrote: > 'custom-elements' As per our offline chat we will keep this seperate. https://codereview.chromium.org/2254623003/diff/80001/ui/login/account_picker... ui/login/account_picker/user_pod_row.js:779: function() {}); On 2016/08/30 18:21:58, jdufault wrote: > emit function Do we need to still emit function?
https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:773: if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('userpod-polymer')) Use id 'custom-elements-user-pod' https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:773: if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('userpod-polymer')) I'd invert the if condition so it is if (!loadedAssets) { register(); loadOnIdle(); } https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:778: html: [{ url: 'chrome://oobe/custom_elements_user_pod.html'}] space before }] https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:781: function() {}); Remove empty function.
https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:773: if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('userpod-polymer')) On 2016/08/30 19:50:40, jdufault wrote: > Use id 'custom-elements-user-pod' Done. https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:773: if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('userpod-polymer')) On 2016/08/30 19:50:40, jdufault wrote: > I'd invert the if condition so it is > > if (!loadedAssets) { > register(); > loadOnIdle(); > } Done. https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:778: html: [{ url: 'chrome://oobe/custom_elements_user_pod.html'}] On 2016/08/30 19:50:40, jdufault wrote: > space before }] Done. https://codereview.chromium.org/2254623003/diff/100001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:781: function() {}); On 2016/08/30 19:50:40, jdufault wrote: > Remove empty function. Done.
https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.css (right): https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... ui/login/account_picker/user_pod_row.css:244: .capslock-on .password-container { Is it possible to have the alignment automatically readjust so we don't need to specify custom styling for a specific app state? https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:1134: setErrorDisplay: function(visible) { toggleDisplayError? toggleErrorShown? setErrorShown? What about using a set function, ie, this.showError = false this.showError = true https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3031: }.bind(this), 200); Where does 200 come from?
https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.css (right): https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... ui/login/account_picker/user_pod_row.css:244: .capslock-on .password-container { On 2016/08/30 21:02:26, jdufault wrote: > Is it possible to have the alignment automatically readjust so we don't need to > specify custom styling for a specific app state? Done. https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:1134: setErrorDisplay: function(visible) { On 2016/08/30 21:02:27, jdufault wrote: > toggleDisplayError? > toggleErrorShown? > setErrorShown? > > What about using a set function, ie, > > this.showError = false > this.showError = true Done. https://codereview.chromium.org/2254623003/diff/120001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3031: }.bind(this), 200); On 2016/08/30 21:02:26, jdufault wrote: > Where does 200 come from? Done.
lgtm https://codereview.chromium.org/2254623003/diff/140001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/140001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:774: 'custom-elements-user-pod')) { double indent the 'custom...' since this is inside a function call https://codereview.chromium.org/2254623003/diff/140001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3032: }.bind(this), 200); Make the 200 a const at the top of the file, or parse the value similar to https://cs.chromium.org/chromium/src/ui/webui/resources/js/util.js?q=ensuretr.... I think it would be better to parse the value so that it is only defined once.
xiyuan@ - Please take a look. Thanks! https://codereview.chromium.org/2254623003/diff/140001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/140001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:774: 'custom-elements-user-pod')) { On 2016/08/30 22:37:34, jdufault wrote: > double indent the 'custom...' since this is inside a function call Done. https://codereview.chromium.org/2254623003/diff/140001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3032: }.bind(this), 200); On 2016/08/30 22:37:34, jdufault wrote: > Make the 200 a const at the top of the file, or parse the value similar to > https://cs.chromium.org/chromium/src/ui/webui/resources/js/util.js?q=ensuretr.... > > I think it would be better to parse the value so that it is only defined once. Done.
https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3031: var style = getComputedStyle(this.focusedPod_); Should the setTimeout/scrollFocusedPodIntoView bit below should only be called if we have a focused pod? Otherwise the timeOut will be 0.
https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3031: var style = getComputedStyle(this.focusedPod_); On 2016/08/30 23:38:32, jdufault wrote: > Should the setTimeout/scrollFocusedPodIntoView bit below should only be called > if we have a focused pod? Otherwise the timeOut will be 0. We could put the timeout inside the if clause and add a else { this.scrollFocusedPodIntoView() ;}. I thought this way would be cleaner.
https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3031: var style = getComputedStyle(this.focusedPod_); On 2016/08/31 00:31:56, sammiequon wrote: > On 2016/08/30 23:38:32, jdufault wrote: > > Should the setTimeout/scrollFocusedPodIntoView bit below should only be called > > if we have a focused pod? Otherwise the timeOut will be 0. > > We could put the timeout inside the if clause and add a else { > this.scrollFocusedPodIntoView() ;}. I thought this way would be cleaner. Okay, so we only want to use a timeout if there is a focused pod? It might be worthwhile adding a comment describing that.
Description was changed from ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
sammiequon@chromium.org changed reviewers: + xiyuan@chromium.org
xiyuan@ - Please take a look. Thanks!
https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:777: html: [{ url: 'chrome://oobe/custom_elements_user_pod.html' }] Would this work for user manager UI? It is on chrome://user-manager/.
https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:777: html: [{ url: 'chrome://oobe/custom_elements_user_pod.html' }] On 2016/08/31 17:16:13, xiyuan wrote: > Would this work for user manager UI? It is on chrome://user-manager/. I just tried it, there is console message saying resource failed to load, but otherwise the gui shows up as before. https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:3031: var style = getComputedStyle(this.focusedPod_); On 2016/08/31 00:37:20, jdufault wrote: > On 2016/08/31 00:31:56, sammiequon wrote: > > On 2016/08/30 23:38:32, jdufault wrote: > > > Should the setTimeout/scrollFocusedPodIntoView bit below should only be > called > > > if we have a focused pod? Otherwise the timeOut will be 0. > > > > We could put the timeout inside the if clause and add a else { > > this.scrollFocusedPodIntoView() ;}. I thought this way would be cleaner. > > Okay, so we only want to use a timeout if there is a focused pod? It might be > worthwhile adding a comment describing that. Done.
lgtm https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2254623003/diff/160001/ui/login/account_picke... ui/login/account_picker/user_pod_row.js:777: html: [{ url: 'chrome://oobe/custom_elements_user_pod.html' }] On 2016/08/31 19:39:10, sammiequon wrote: > On 2016/08/31 17:16:13, xiyuan wrote: > > Would this work for user manager UI? It is on chrome://user-manager/. > > I just tried it, there is console message saying resource failed to load, but > otherwise the gui shows up as before. nit: If the load is optional, can we add a cr.isChromeOS to the "if" above to skip it at all? Can we also get rid of chrome://oobe since that should be default document base.
The CQ bit was checked by sammiequon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jdufault@chromium.org, xiyuan@chromium.org Link to the patchset: https://codereview.chromium.org/2254623003/#ps200001 (title: "Added chromeOS check.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sammiequon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org, jdufault@chromium.org Link to the patchset: https://codereview.chromium.org/2254623003/#ps220001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #10 (id:220001)
Message was sent while issue was closed.
Description was changed from ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Submit button added to user pod. This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20.... Moves the caps lock button accordingly. BUG=638643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/29276a7a0b4a0d59fa0a420cf9e7885286020bc4 Cr-Commit-Position: refs/heads/master@{#415804} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/29276a7a0b4a0d59fa0a420cf9e7885286020bc4 Cr-Commit-Position: refs/heads/master@{#415804} |
