Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2254053002: Move inlining of recognized SIMD methods to the flow-graph inliner. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move inlining of recognized SIMD methods to the flow-graph inliner. This allows inlining of these methods in the AOT optimizer. Also fix missing inlining of some SIMD constructors (Float32x4FromInt32x4Bits and Int32x4FromFloat32x4Bits) BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1e7dc8a5e80ea59c6f12e2c529227c50bcc5f553

Patch Set 1 #

Patch Set 2 : add missing guard for speculative inlining #

Total comments: 2

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -852 lines) Patch
M runtime/vm/aot_optimizer.h View 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 3 chunks +9 lines, -245 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 2 chunks +546 lines, -38 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M runtime/vm/jit_optimizer.h View 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 4 chunks +6 lines, -508 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 4 months ago (2016-08-17 21:28:26 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/2254053002/diff/20001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://chromiumcodereview.appspot.com/2254053002/diff/20001/runtime/vm/flow_graph_inliner.cc#newcode2900 runtime/vm/flow_graph_inliner.cc:2900: Definition* last; I think this would read easier ...
4 years, 4 months ago (2016-08-18 18:09:54 UTC) #4
Florian Schneider
https://codereview.chromium.org/2254053002/diff/20001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/2254053002/diff/20001/runtime/vm/flow_graph_inliner.cc#newcode2900 runtime/vm/flow_graph_inliner.cc:2900: Definition* last; On 2016/08/18 18:09:54, rmacnak wrote: > I ...
4 years, 4 months ago (2016-08-18 19:42:44 UTC) #5
Florian Schneider
4 years, 4 months ago (2016-08-18 19:50:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
1e7dc8a5e80ea59c6f12e2c529227c50bcc5f553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698