Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 22495005: [Android] Fixes exit code on invalid command to test_runner.py (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes exit code on invalid command to test_runner.py NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216523

Patch Set 1 #

Patch Set 2 : Use the error function to print a message and exit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/test_runner.py View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gkanwar1
7 years, 4 months ago (2013-08-08 18:03:47 UTC) #1
frankf
lgtm
7 years, 4 months ago (2013-08-08 18:04:56 UTC) #2
gkanwar1
Changed from print_help and exit to using the error function. I believe we didn't use ...
7 years, 4 months ago (2013-08-08 18:14:39 UTC) #3
frankf
still lgtm
7 years, 4 months ago (2013-08-08 18:33:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/22495005/6001
7 years, 4 months ago (2013-08-08 19:48:25 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 01:08:54 UTC) #6
Message was sent while issue was closed.
Change committed as 216523

Powered by Google App Engine
This is Rietveld 408576698