build/android/test_runner.py - Issue 22495005: [Android] Fixes exit code on invalid command to test_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/test_runner.py

Issue 22495005: [Android] Fixes exit code on invalid command to test_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use the error function to print a message and exit Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/test_runner.py

diff --git a/build/android/test_runner.py b/build/android/test_runner.py

index 8655720810882b7b9c3d834348890352510315bb..a0e6ba30b71d92f222c30ed7ba5824c854e1cfed 100755

--- a/build/android/test_runner.py

+++ b/build/android/test_runner.py

@@ -676,8 +676,7 @@ def main(argv):

command_list=VALID_COMMANDS.keys())

if len(argv) < 2 or argv[1] not in VALID_COMMANDS:

- option_parser.print_help()

- return 0

+ option_parser.error('Invalid command.')

command = argv[1]

VALID_COMMANDS[command].add_options_func(option_parser)

options, args = option_parser.parse_args(argv)

« no previous file with comments | « no previous file | no next file » | no next file with comments »